Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "prefer mount API over bind" #12132

Closed
wants to merge 1 commit into from
Closed

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Sep 17, 2024

This reverts commit f9c7a0c.

@ndeloof ndeloof marked this pull request as draft September 17, 2024 06:51
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.27%. Comparing base (e885bc0) to head (85bc546).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/compose/create.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12132      +/-   ##
==========================================
+ Coverage   51.04%   51.27%   +0.23%     
==========================================
  Files         149      149              
  Lines       14509    14518       +9     
==========================================
+ Hits         7406     7444      +38     
+ Misses       6356     6326      -30     
- Partials      747      748       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glours
Copy link
Contributor

glours commented Sep 23, 2024

Done in #12141

@glours glours closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants