-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert commits link to mount API over bind changes #12141
Conversation
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This experiment demonstrate Mount
and Bind
API are not equivalent, as mount require client to know about engine constraints (typically "must use either propagation mode "rslave" or "rshared" when mount source is within the daemon root").
compse-go makes the assumption a bind can be safely expanded in to a mount, so the "long syntax", but actually this is wrong. We will have to manage this in compose-go in a better way, to really distinguish user intent to use mount-specific options. Maybe we should introduce a mount
section and deprecate use of advanced volume attributes (like subpath
) which are only supported by the mount
API, to fully align with the docker CLI
@ndeloof IIUC this worked on a bare Linux machine, but failed with desktop? Do we know what Desktop did that made it fail? |
The previous release failed in my Linux machine. |
@prashant-shahi Yes; the long story was that;
Step
This PR reverts all of the above, pending changes in Docker Desktop to allow this again. |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.29.6` -> `v2.29.7` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.29.7`](https://github.com/docker/compose/releases/tag/v2.29.7) [Compare Source](docker/compose@v2.29.6...v2.29.7) #### What's Changed ##### 🐛 Fixes - fix regressions using mount API for bind mounts by [@​glours](https://github.com/glours) in docker/compose#12141 **Full Changelog**: docker/compose@v2.29.6...v2.29.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
What I did
I reverted the following commits:
Related issue
fixes #12139 #12140
(not mandatory) A picture of a cute animal, if possible in relation to what you did