Fix issue #162 (docker-credential-pass does not work with username containing forward-slash) #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> Signed-off-by: Davide Cosentino <davide.cosentino@oracle.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> Signed-off-by: Davide Cosentino <davide.cosentino@oracle.com>
Linters 'deadcode', 'structcheck', 'varcheck' are deprecated since v1.49.0 and had been replaced by 'unused'. Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> Signed-off-by: Davide Cosentino <davide.cosentino@oracle.com>
Signed-off-by: Davide Cosentino <davide.cosentino@oracle.com>
thaJeztah
reviewed
May 28, 2023
| _, err := p.runPass(creds.Secret, "insert", "-f", "-m", path.Join(PASS_FOLDER, encoded, creds.Username)) | ||
| username := creds.Username | ||
| if strings.Contains(username, "/") { | ||
| username = base64.URLEncoding.EncodeToString([]byte(creds.Username)) |
There was a problem hiding this comment.
Do we know if pass supports spaces in usernames? If it does, perhaps we could swap "/" for " " (as I don't think we support spaces in usernames, so that would be non-ambiguous).
Advantage would be that the username would still be readable (I don't use pass myself, but ISTR there's tools to manage credentials in pass, which would otherwise see a base64-encoded username (which is not very user-friendly 😅)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to fix issue #162 (docker-credential-pass does not work with username containing forward-slash).
Based on @sebageek commit.