-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass: base64 encoded username with backward compatility #288
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 54.68% 55.14% +0.46%
==========================================
Files 9 9
Lines 673 680 +7
==========================================
+ Hits 368 375 +7
Misses 262 262
Partials 43 43
☔ View full report in Codecov by Sentry. |
5fd7864
to
fe640fd
Compare
Signed-off-by: Davide Cosentino <davide.cosentino@oracle.com>
fe640fd
to
f78bca3
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
f78bca3
to
5a3e1bb
Compare
Thanks @crazy-max - I'll try to have a look at this one. Some things we should consider when merging some of the pending PRs;
So, probably we should have a look at what's already merged, and what's still pending, and then decide what change should go into what "minor" or "patch" release. I think so far, the changes that were merged since v0.7.0 are all relatively safe (mostly fixes, and the addition of the |
@crazy-max this one needs a rebase 🙈 |
carry and closes #267
fixes #162
The allowed characters for usernames in Unix systems typically follow these guidelines:
A-Z
,a-z
) are allowed.0-9
are allowed._
. but also-
,
.
.Looking at
shadow
utility and the regexp used it seems to match https://github.com/shadow-maint/shadow/blob/dcc90658fd672c63e5498619e77f2d5a3d95f7d7/libmisc/chkname.c#L28-L73But there are some cases like the credential helper where we can have other special characters to be handled.
shadow
also needed to allow non-standard usernames. e.g., for compatibility with Samba machine accounts: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=42874. So it seems ok to rely on base64 encoding for the username.