DOCK-2464: Display ignored lambdaevents appropriately #1849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the GitHub Apps lambda event table so it displays "Ignored" in the "Success" column when the
LambdaEvent
'signored
property is true. Otherwise, the UI remains the same.Additionally, it fixes a "search" smoke test failure which was induced by a recent search change that turns underscores into token breaks. Now, ES will split the search term "dockstore_i" into two words at the underscore, so, in addition to returning literal matches, it will return matches for either of the component words, ranked lower. Before, a search for "dockstore_i" returned no results, and now it returns some, breaking the tests. The PR changes search term "dockstore_i" to another nonexistent word "dhockstore" that doesn't include underscores.
Review Instructions
Install the github app on a repo, do two pushes to it in rapid succession (within 20 seconds of each other), wait five minutes, view the Apps Logs, and confirm that two new events have appeared, one of which should be marked "Ignored".
Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2464
dockstore/dockstore#5674
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run build
markdown-wrapper
component, which does extra sanitizationnpm audit
and ensure you are not introducing new vulnerabilities