Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCK-2464: Display ignored lambdaevents appropriately #1849

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

svonworl
Copy link
Contributor

@svonworl svonworl commented Oct 4, 2023

Description
This PR changes the GitHub Apps lambda event table so it displays "Ignored" in the "Success" column when the LambdaEvent's ignored property is true. Otherwise, the UI remains the same.

Additionally, it fixes a "search" smoke test failure which was induced by a recent search change that turns underscores into token breaks. Now, ES will split the search term "dockstore_i" into two words at the underscore, so, in addition to returning literal matches, it will return matches for either of the component words, ranked lower. Before, a search for "dockstore_i" returned no results, and now it returns some, breaking the tests. The PR changes search term "dockstore_i" to another nonexistent word "dhockstore" that doesn't include underscores.

Review Instructions
Install the github app on a repo, do two pushes to it in rapid succession (within 20 seconds of each other), wait five minutes, view the Apps Logs, and confirm that two new events have appeared, one of which should be marked "Ignored".

Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2464
dockstore/dockstore#5674

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f7222a2) 40.76% compared to head (b80adec) 40.74%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1849      +/-   ##
===========================================
- Coverage    40.76%   40.74%   -0.02%     
===========================================
  Files          364      364              
  Lines        11232    11232              
  Branches      2867     2867              
===========================================
- Hits          4579     4577       -2     
- Misses        4356     4358       +2     
  Partials      2297     2297              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svonworl svonworl self-assigned this Oct 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@svonworl svonworl merged commit 37729cb into develop Oct 5, 2023
20 checks passed
@svonworl svonworl deleted the feature/dock-2464/support-ignored-lamdbaevents branch October 5, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants