Skipped GitHub events should appear in the GitHub App Logs

[coverbeck]

Describe the bug
As part of the optimization for handling apps for GitHub events, #5653, we now skip events that are no longer applicable, e.g., if two updates come in right away, the first update will be skipped if the corresponding commit is not at the head of the branch. This is good.

But, the event also does not show up in the GitHub app logs.

To Reproduce
Steps to reproduce the behavior:

1. Do 2 pushes of a registered .dockstore.yml workflow as quickly as you can, e.g., within 15 seconds of each other.
2. Wait for 2 minutes
3. Look at the GitHub App Logs for the org; you'll only see the second push.

Expected behavior
I expect to see both pushes in the logs -- it's the GitHub app logs, not the GitHub app logs of events we processed.

If we do this, we'd need something to indicate the event was not processed.

I'm 50/50 on this, and I'm OK with the issue being rejected. If need be, the Dockstore team could always piece this together with our internal logs. And it's unlikely that an end-user would notice a missing event in the logs.

But still, as I was verifying SEAB-5770, I was looking for the events, I was surprised not to see them.

Additional context
[Domain] - https://qa.dockstore.org

Webservice

• e5e25ab

UI

• 2.11.1-66-gf92a4543

Deploy

• 1.14.1-41-g0725504

cwlParsingLambdaVersion: n/a

wdlParsingLambdaVersion: n/a

nextflowParsingLambdaVersion: n/a

galaxyParsingLambdaVersion: 0.0.6

checkUrlLambdaVersion: n/a

┆Issue is synchronized with this Jira Story
┆Fix Versions: Dockstore 1.15
┆Issue Number: DOCK-2464
┆Sprint: 122 - Ural
┆Issue Type: Story

[unito-bot]

➤ Kathy Tran commented:

Verified in QA by making two rapid changes to a GitHub Apps workflow and confirming that two events showed up in the GitHub App logs, one of which was ignored.

Moving to Done

[Domain] - https://qa.dockstore.org ( https://qa.dockstore.org|smart-link )

Webservice ( https://github.com/dockstore/dockstore/commits/8b4da4b ) - 8b4da4b

UI ( https://github.com/dockstore/dockstore-ui2/commits/37729cbb ) - 2.11.1-70-g37729cbb

Deploy ( https://github.com/dockstore/dockstore-deploy/commits/7ae1315 ) - 1.14.1-47-g7ae1315

cwlParsingLambdaVersion: n/a

wdlParsingLambdaVersion: n/a

nextflowParsingLambdaVersion: n/a

galaxyParsingLambdaVersion: 0.0.6

checkUrlLambdaVersion: n/a