Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundle size from the home page and documentation #1257

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Remove bundle size from the home page and documentation #1257

merged 2 commits into from
Jul 2, 2020

Conversation

kirbyfern
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe: Just remove bundle size, will create a separate branch for the LighthouseCI

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
    fix issue remove bundle size from Docsify home page #1211, will create a separate branch for the Lighthouse integration

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Other information:


  • DO NOT include files inside lib directory.

@vercel
Copy link

vercel bot commented Jun 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/286to1p0e
✅ Preview: https://docsify-preview-git-fork-kirbygit-remove-bundle-size.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 24587ff:

Sandbox Source
dazzling-meadow-g9o7t Configuration

@kirbyfern kirbyfern marked this pull request as draft July 2, 2020 15:28
@kirbyfern kirbyfern marked this pull request as ready for review July 2, 2020 15:29
@kirbyfern
Copy link
Contributor Author

Is there any specifics for this?

@anikethsaha anikethsaha merged commit 163681a into docsifyjs:develop Jul 2, 2020
trusktr added a commit that referenced this pull request Jul 4, 2020
* develop:
  docs: removed codefund docs and plugin (#1262)
  docs: remove bundle size from the home page and documentation (#1257)
  fix: search can not search the table header (#1256)
  fix: after setting the background image, the button is obscured (#1234)
  Fix: fixed onlycover flag in mobile (#1243)
  fix: Updated docs with instructions for installing specific version (fixes #780) (#1225)
  fix: Add error handling for missing dependencies (fixes #1210) (#1232)
  [documdocs:  deploy docsify in docker. (#1241)
  docs: Add embed gist instructions to Embed Files (fixes #932 ) (#1238)
  chore: add changelog 4.11.4
  [build] 4.11.4
  feat: added html sanitizer for remote rendering (#1128)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants