Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed codefund docs and plugin [Fix#1258] #1262

Merged

Conversation

aemmadi
Copy link
Contributor

@aemmadi aemmadi commented Jul 2, 2020

Summary
Fixes #1258
Removed the existence of codefund in docsify, (i.e. codefund documentation and the plugin used by docsify)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe: Removed codefund plugin

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

@vercel
Copy link

vercel bot commented Jul 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/aj1ify8xt
✅ Preview: https://docsify-preview-git-fork-mlh-fellowship-remove-codefund-plugin.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f219562:

Sandbox Source
objective-morse-41uf3 Configuration

@anikethsaha
Copy link
Member

can you update your branch.

@anikethsaha anikethsaha merged commit c78cb11 into docsifyjs:develop Jul 2, 2020
@trusktr
Copy link
Member

trusktr commented Jul 3, 2020

This is fixed upstream: njleonzhang/docsify-plugin-codefund#6

Probably should add it back to the plugin list now.

Also maybe it is worth simply mentioning browser support for any plugin, if we happen to know, f.e. ("does not work in IE 11").

Wee can say at the top of the page something like "Note, any plugins created by third party authors are not guaranteed to have the same browser support as Docsify", and not remove them.

trusktr added a commit that referenced this pull request Jul 4, 2020
* develop:
  docs: removed codefund docs and plugin (#1262)
  docs: remove bundle size from the home page and documentation (#1257)
  fix: search can not search the table header (#1256)
  fix: after setting the background image, the button is obscured (#1234)
  Fix: fixed onlycover flag in mobile (#1243)
  fix: Updated docs with instructions for installing specific version (fixes #780) (#1225)
  fix: Add error handling for missing dependencies (fixes #1210) (#1232)
  [documdocs:  deploy docsify in docker. (#1241)
  docs: Add embed gist instructions to Embed Files (fixes #932 ) (#1238)
  chore: add changelog 4.11.4
  [build] 4.11.4
  feat: added html sanitizer for remote rendering (#1128)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove codefund plugin from the docs.
4 participants