Add Configless Metadata Cache #675
Conversation
| use function is_file; | ||
|
|
||
| /** @internal */ | ||
| final class MetadataCacheWarmer extends AbstractPhpFileCacheWarmer |
There was a problem hiding this comment.
I'll propose adding this to the doctrine-bridge in Symfony so we can drop this class. In the interest of "getting on with it", I decided to first add it here since this will only be in 5.4.
| @@ -23,6 +23,8 @@ | |||
| * | |||
| * In the process of generating hydrators the cache for all the metadata is primed also, | |||
| * since this information is necessary to build the hydrators in the first place. | |||
| * | |||
| * @internal | |||
There was a problem hiding this comment.
I decided to make all these internal. Not that it makes much of a difference, but at least it communicates that users shouldn't interact with this directly.
This deprecates configuring a metadata cache in favour of automatic configuration.
alcaeus
force-pushed
the
improve-metadata-caching
branch
from
9a1d656 to
51b509f
Compare
| protected function loadCacheDriver(string $cacheName, string $objectManagerName, array $cacheDriver, ContainerBuilder $container) | ||
| { | ||
| if (isset($cacheDriver['namespace'])) { | ||
| // @todo wrap |
| case 'service': | ||
| $container->setAlias($cacheDriverServiceId, new Alias($cacheDriver['id'], false)); | ||
|
|
||
| // @todo wrap conditionally |
| break; | ||
|
|
||
| default: | ||
| // @todo wrap |
| * | ||
| * @throws InvalidArgumentException | ||
| */ | ||
| protected function loadCacheDriver(string $cacheName, string $objectManagerName, array $cacheDriver, ContainerBuilder $container) |
There was a problem hiding this comment.
This looks like something that would be nice to have in the bridge
There was a problem hiding this comment.
Or is creating caches to be gone in next major?
|
Closing as I don't intend to continue working on this in the near future. If somebody wants to pick this up, please feel free to re-use the work I've already done. |
This PR deprecates the
metadata_cache_driverconfig key in favour of automatic configuration. In debug mode, it creates an ArrayAdapter, meaning that the cache is only valid per request. This is usually desired in a development environment. When debug is disabled, it creates a PhpArrayAdapter, backed by an array cache. The cache is warmed up and stored in the file system. Since this information shouldn't be shared between multiple instances of the code, it is only logical to store this in the cache folder in an efficient format. This also mirrors a decision made in the ORM bundle to deprecate the config.Note: This PR contains a commit from #674. I'll rebase this PR once the other one has been merged.