Mark Module, ConfigProvider, option classes and factories as final
#707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driehle
force-pushed
the
feature/final-classes
branch
from
0001656 to
e1365a2
Compare
driehle
force-pushed
the
feature/final-classes
branch
from
e1365a2 to
da66832
Compare
driehle
requested review from
greg0ire,
SenseException,
TomHAnderson and
a team
greg0ire
approved these changes
Jan 4, 2022
SenseException
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Module and ConfigProvider classes, as well as the option classes and all factories are no valid extension points. They are now marked as final.
This is in line with doctrine/DoctrineModule#766.