Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Module, ConfigProvider, option classes and factories as final #707

Merged
merged 1 commit into from
Jan 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ConfigProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
/**
* Config provider for DoctrineORMModule config
*/
class ConfigProvider
final class ConfigProvider
{
/**
* @return mixed[]
Expand Down
2 changes: 1 addition & 1 deletion src/Module.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* Base module for Doctrine ORM.
*/
class Module implements
final class Module implements
ControllerProviderInterface,
ConfigProviderInterface,
DependencyIndicatorInterface
Expand Down
2 changes: 1 addition & 1 deletion src/Options/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/**
* Configuration options for an ORM Configuration
*/
class Configuration extends DBALConfiguration
final class Configuration extends DBALConfiguration
{
/**
* Set the cache key for the metadata cache. Cache key
Expand Down
2 changes: 1 addition & 1 deletion src/Options/DBALConnection.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/**
* DBAL Connection options
*/
class DBALConnection extends AbstractOptions
final class DBALConnection extends AbstractOptions
{
/**
* Set the configuration key for the Configuration. Configuration key
Expand Down
2 changes: 1 addition & 1 deletion src/Options/EntityManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

use Laminas\Stdlib\AbstractOptions;

class EntityManager extends AbstractOptions
final class EntityManager extends AbstractOptions
{
/**
* Set the configuration key for the Configuration. Configuration key
Expand Down
2 changes: 1 addition & 1 deletion src/Options/EntityResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use function class_exists;
use function sprintf;

class EntityResolver extends AbstractOptions
final class EntityResolver extends AbstractOptions
{
/**
* Set the configuration key for the EventManager. Event manager key
Expand Down
2 changes: 1 addition & 1 deletion src/Options/SQLLoggerCollectorOptions.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* Configuration options for an collector
*/
class SQLLoggerCollectorOptions extends AbstractOptions
final class SQLLoggerCollectorOptions extends AbstractOptions
{
/** @var string name to be assigned to the collector */
protected string $name = 'orm_default';
Expand Down
2 changes: 1 addition & 1 deletion src/Options/SecondLevelCacheConfiguration.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* Configuration options for Second Level Cache
*/
class SecondLevelCacheConfiguration extends AbstractOptions
final class SecondLevelCacheConfiguration extends AbstractOptions
{
/**
* Enable the second level cache configuration
Expand Down
2 changes: 1 addition & 1 deletion src/Service/CliConfiguratorFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Interop\Container\ContainerInterface;
use Laminas\ServiceManager\Factory\FactoryInterface;

class CliConfiguratorFactory implements FactoryInterface
final class CliConfiguratorFactory implements FactoryInterface
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/ConfigurationFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use function method_exists;
use function sprintf;

class ConfigurationFactory extends DoctrineConfigurationFactory
final class ConfigurationFactory extends DoctrineConfigurationFactory
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/DBALConnectionFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/**
* DBAL Connection ServiceManager factory
*/
class DBALConnectionFactory extends AbstractFactory
final class DBALConnectionFactory extends AbstractFactory
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/DoctrineObjectHydratorFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Interop\Container\ContainerInterface;
use Laminas\ServiceManager\Factory\FactoryInterface;

class DoctrineObjectHydratorFactory implements FactoryInterface
final class DoctrineObjectHydratorFactory implements FactoryInterface
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/EntityManagerAliasCompatFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* Factory that provides the `Doctrine\ORM\EntityManager` alias for `doctrine.entitymanager.orm_default`
*/
class EntityManagerAliasCompatFactory implements FactoryInterface
final class EntityManagerAliasCompatFactory implements FactoryInterface
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/EntityManagerFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

use function assert;

class EntityManagerFactory extends AbstractFactory
final class EntityManagerFactory extends AbstractFactory
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/EntityResolverFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

use function assert;

class EntityResolverFactory extends AbstractFactory
final class EntityResolverFactory extends AbstractFactory
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/MappingCollectorFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
* Service factory responsible for instantiating {@see \DoctrineORMModule\Collector\MappingCollector}
*/
class MappingCollectorFactory extends AbstractFactory
final class MappingCollectorFactory extends AbstractFactory
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/MigrationsCommandFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
/**
* Service factory for migrations command
*/
class MigrationsCommandFactory implements FactoryInterface
final class MigrationsCommandFactory implements FactoryInterface
{
private string $commandClassName;

Expand Down
2 changes: 1 addition & 1 deletion src/Service/ObjectMultiCheckboxFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
* Factory for {@see ObjectMultiCheckbox}
*/
class ObjectMultiCheckboxFactory implements FactoryInterface
final class ObjectMultiCheckboxFactory implements FactoryInterface
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/ObjectRadioFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
* Factory for {@see ObjectRadio}
*/
class ObjectRadioFactory implements FactoryInterface
final class ObjectRadioFactory implements FactoryInterface
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/ObjectSelectFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
* Factory for {@see ObjectSelect}
*/
class ObjectSelectFactory implements FactoryInterface
final class ObjectSelectFactory implements FactoryInterface
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/ReservedWordsCommandFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Interop\Container\ContainerInterface;
use Laminas\ServiceManager\Factory\FactoryInterface;

class ReservedWordsCommandFactory implements FactoryInterface
final class ReservedWordsCommandFactory implements FactoryInterface
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/RunSqlCommandFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Interop\Container\ContainerInterface;
use Laminas\ServiceManager\Factory\FactoryInterface;

class RunSqlCommandFactory implements FactoryInterface
final class RunSqlCommandFactory implements FactoryInterface
{
/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion src/Service/SQLLoggerCollectorFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
/**
* DBAL Configuration ServiceManager factory
*/
class SQLLoggerCollectorFactory implements FactoryInterface
final class SQLLoggerCollectorFactory implements FactoryInterface
{
protected string $name;

Expand Down