Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResultStatement::fetch() returns null instead of false with mysqli #2497

Closed
PatrickLouys opened this issue Sep 7, 2016 · 4 comments · Fixed by #2500
Closed

ResultStatement::fetch() returns null instead of false with mysqli #2497

PatrickLouys opened this issue Sep 7, 2016 · 4 comments · Fixed by #2500
Assignees
@Ocramius
Labels
Bug mysqli Prepared Statements
Milestone
2.5.5

Comments

@PatrickLouys
Copy link
Contributor

ResultStatement::fetch() returns null with mysqli, false with sqlsrv. Documented is that it always returns false http://www.doctrine-project.org/api/dbal/2.0/class-Doctrine.DBAL.Driver.ResultStatement.html

http://www.doctrine-project.org/api/dbal/2.3/source-class-Doctrine.DBAL.Driver.Mysqli.MysqliStatement.html#243

I guess the code here should return false instead of null?
@PatrickLouys
Copy link
Contributor Author

If this is confirmed as a bug I can make a quick PR.

@kimhemsoe
Copy link
Member

This seems indeed to be a bug.

Confirmed.

@PatrickLouys PatrickLouys mentioned this issue Sep 7, 2016
Closed
@Ocramius Ocramius added the Bug label Sep 7, 2016
@PatrickLouys PatrickLouys mentioned this issue Sep 8, 2016
Merged
Ocramius added a commit that referenced this issue Sep 8, 2016
@Ocramius
#2497 #2500 simplified test case scenario (inlined statement)
f90c0b0
Ocramius added a commit that referenced this issue Sep 8, 2016
@Ocramius
Merge branch 'fix/#2500-#2497-return-false-from-mysqli-statement-when…
a6d3d16 
…-nothing-is-fetched'

Close #2500
Close #2497
Ocramius added a commit that referenced this issue Sep 8, 2016
@Ocramius
#2497 #2500 simplified test case scenario (inlined statement)
f1ccaed
Ocramius added a commit that referenced this issue Sep 8, 2016
@Ocramius
Merge branch 'fix/#2500-#2497-return-false-from-mysqli-statement-when…
75ac2f6 
…-nothing-is-fetched-2.5' into 2.5

Close #2500
Close #2497
@Ocramius Ocramius added this to the 2.5.5 milestone Sep 8, 2016
@Ocramius Ocramius self-assigned this Sep 8, 2016
@Ocramius
Copy link
Member

Ocramius commented Sep 8, 2016

Fixed via #2500

@Ocramius Ocramius mentioned this issue Oct 1, 2016
Merged
1 task
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
Bug mysqli Prepared Statements
Projects
None yet
Milestone
2.5.5
Development

Successfully merging a pull request may close this issue.

Making sure that fetch returns false if nothing is found
3 participants
@Ocramius @kimhemsoe @PatrickLouys