Making sure that fetch returns false if nothing is found #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -242,7 +242,7 @@ public function fetch($fetchMode = null) | |||
| { | |||
| $values = $this->_fetch(); | |||
| if (null === $values) { | |||
| return null; | |||
There was a problem hiding this comment.
What happens when a null is actually retrieved? Is it supposed to always retrieve an array?
There was a problem hiding this comment.
I'm not sure that I understand your question.
It's supposed to return false or an array (boolean|array).
Now that I think about it, _fetch is not even supposed to return null in the first place, so that should be fixed as well I suppose.
Ocramius
added a commit
that referenced
this pull request
Sep 8, 2016
Ocramius
added a commit
that referenced
this pull request
Sep 8, 2016
|
@PatrickLouys merged, thanks! |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added test to make sure that fetch returns false if nothing is found
fixed mysqli
Resolves #2497