Fluent methods in QueryBuilder are now documented as returning $this
#2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trivial. I don't care.... Thanks anyways! |
|
@deeky666 thanks for merging! |
|
@Ocramius is there a chance this gets backported into 2.5? Code analysis tools like phpstan/phpstan or vimeo/psalm complain about the code which extends the query builder and then expects the extended version. |
|
@morozov if you have the rights and think this is relevant, you can attempt
a backport
On 15 Jun 2017 22:57, "Sergei Morozov" <notifications@github.com> wrote:
@Ocramius <https://github.com/ocramius> is there a chance this gets
backported into 2.5? Code analysis tools like phpstan/phpstan
<https://packagist.org/packages/phpstan/phpstan> or vimeo/psalm
<https://packagist.org/packages/vimeo/psalm> complain about the code which
extends the query builder and then expects the extended version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2384 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJakBu6UthIs2sWzQlJlFNY2ItbDGXXks5sEZqegaJpZM4Ia-wa>
.
|
morozov
added a commit
that referenced
this pull request
Jun 15, 2017
…ented-as-returning-this' into 2.5 Backport #2384 to 2.5.x
|
Backported to |
|
@morozov thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the discussion in #2349 i would rather suggest to document the return type for the fluent interfaces methods with
$this.phpDocumentor recommends
$thisto be used for refer "This exact object instance, usually used to denote a fluent interface." instead ofself"An object of the class where this type was used, if inherited it will still represent the class where it was originally defined.".