Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgres: correctly produce alter table sql comment to update column definition #3158

Merged
merged 2 commits into from
Oct 16, 2018
Merged

postgres: correctly produce alter table sql comment to update column definition #3158

merged 2 commits into from
Oct 16, 2018

Conversation

bendavies
Copy link
Contributor

@bendavies bendavies commented May 21, 2018 •
edited
Loading

Q A
Type bug
BC Break no
Fixed issues

Summary

The schema diff for postgres wasn't correctly updating the column comment for an altered column, for example updating a column type from datetime to datetime_immutable

@bendavies bendavies force-pushed the postgres-alter-table-column-comment branch 2 times, most recently from 63ff2c5 to 0dab05b Compare May 21, 2018 11:29
@bendavies bendavies changed the title correctly produce alter table sql to update column comment under post… postgres: correctly produce alter table sql to update column definition May 21, 2018
@bendavies bendavies force-pushed the postgres-alter-table-column-comment branch 2 times, most recently from 2910796 to 3753d04 Compare May 21, 2018 11:33
@bendavies bendavies changed the title postgres: correctly produce alter table sql to update column definition postgres: correctly produce alter table sql comment to update column definition May 21, 2018
@bendavies bendavies force-pushed the postgres-alter-table-column-comment branch 2 times, most recently from 2d9082e to 4009a6f Compare May 21, 2018 11:48
@bendavies bendavies changed the base branch from 2.6 to master May 21, 2018 11:48
@bendavies bendavies force-pushed the postgres-alter-table-column-comment branch 2 times, most recently from ab31806 to 81c9bb1 Compare May 21, 2018 16:19
@bendavies bendavies force-pushed the postgres-alter-table-column-comment branch 2 times, most recently from 6c68c8d to 6700ca4 Compare October 16, 2018 14:53
@bendavies bendavies force-pushed the postgres-alter-table-column-comment branch from 6700ca4 to 8a7208d Compare October 16, 2018 15:19
@bendavies
Copy link
Contributor Author

@Ocramius should be good, and rebased.

Ocramius
Ocramius approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ocramius Ocramius self-assigned this Oct 16, 2018
@Ocramius Ocramius added this to the 2.9.0 milestone Oct 16, 2018
@Ocramius
Copy link
Member

@morozov can you merge/backport this one, when you got a sec?

@morozov morozov merged commit ff30f9a into doctrine:master Oct 16, 2018
morozov added a commit that referenced this pull request Oct 16, 2018
@morozov
Merge branch 'bpo/2.8/#3158' into 2.8
bfe33c3
@bendavies
Copy link
Contributor Author

thanks!

@morozov morozov modified the milestones: 2.9.0, 2.8.1 Dec 2, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Bug PostgreSQL Schema Comparison Schema Management Schema Type Mapping Types
Projects
None yet
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bendavies @Ocramius @morozov