Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for URL to account for master-slave and pooling-shard connections #3201

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Fix support for URL to account for master-slave and pooling-shard connections #3201

merged 1 commit into from
Aug 18, 2018

Conversation

stof
Copy link
Member

@stof stof commented Jun 29, 2018

Q A
Type bug/feature
BC Break no
Fixed issues

Summary

When adding support for url-based configuration, it was implemented at the DriverManager level rather than at the Connection level (which indeed has a bunch of advantages). Due to that, MasterSlaveConnection and PoolingShardConnection were missing support for the URL because the params are not at the top-level, but in sub-keys.
Moving the parsing of the URL to the connection itself when dealing with params would probably require much more work than making DriverManager aware of the config structure for these 2 special connections.

I would consider it as a bugfix for the URL support (and so I hope it gets cherry-picked at least in 2.7), but that's your choice.

@stof
Copy link
Member Author

stof commented Jun 29, 2018

I would even appreciate a backport to the 2.6 branch btw, as I'm currently unable to upgrade DBAL (due to being unable to upgrade the ORM because of a regression affecting me)

@deguif deguif mentioned this pull request Aug 9, 2018
Closed
@deguif
Copy link

deguif commented Aug 9, 2018

Any chance to get this merged?

morozov
morozov reviewed Aug 9, 2018
View reviewed changes
tests/Doctrine/Tests/DBAL/DriverManagerTest.php
'port' => 11211,
];

foreach ($expected as $key => $value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to use self::assertArraySubset() instead?

@morozov morozov merged commit cf98cc9 into doctrine:master Aug 18, 2018
@morozov
Copy link
Member

morozov commented Aug 18, 2018

Thank you @stof!

@stof stof deleted the parse_url branch August 20, 2018 07:27
@stof
Copy link
Member Author

stof commented Aug 20, 2018

@morozov will this get backported or no ?

@morozov
Copy link
Member

morozov commented Aug 20, 2018

@stof, no. It doesn't look that severe to make an exception and revive an unsupported branch. You should be able to pass structured connection parameters instead of a URL and use master/slave connections and sharding on older DBAL versions.

@stof
Copy link
Member Author

stof commented Aug 20, 2018

@morozov using structured parameters is not a good experience on heroku, as it means I cannot use the %env()% feature of Symfony to read the URL at runtime (and so I need to manually do a deployment when they switch to the failover, defeating the HA setup).
I will keep using my own fork for now, until I can upgrade the ORM to a supported version (which is what is blocking DBAL to an unsupported version).

@deguif
Copy link

deguif commented Aug 31, 2018 •
edited
Loading

Would it be possible to get a release published with this fix?
Thanks @stof for solving this annoying issue ;)

@Majkl578 Majkl578 added this to the 2.9.0 milestone Aug 31, 2018
@Majkl578
Copy link
Contributor

@deguif Right now this is targeting 2.9.0, whether this can be considered a bugfix and backported to 2.8.x is up to @morozov.

@deguif
Copy link

deguif commented Aug 31, 2018

Any ETA about the release of 2.9.0?

@Ocramius
Copy link
Member

Ocramius commented Aug 31, 2018 via email

@stof
Copy link
Member Author

stof commented Nov 23, 2018

@morozov any chance to get a release including this fix ?

@morozov
Copy link
Member

morozov commented Nov 23, 2018

@stof right now, master is in an unstable state due to #3336. We'll need some more time to double check if there are other regressions caused by the conversion of weak comparisons to strict.

rgrellmann added a commit to Rossmann-IT/dbal that referenced this pull request Apr 22, 2020
@rgrellmann
Merge tag 'v2.9.0' into oracle122
5d827b5 
Release v2.9.0

This is a minor release of Doctrine DBAL that aggregates over 40 fixes and improvements developed by 18 contributors over the last 5 months.

This release includes all changes of the 2.8.x series, as well as feature additions and improvements that couldn't land in patch releases.

## Backwards Compatibility Breaks

This doesn't contain any intentional Backwards Compatibility (BC) breaks.

## Deprecations

* The usage of `NULL` to specify the absence of an offset in `LIMIT`ed queries is deprecated. Use `0` instead.
* It's not recommended to rely on the default length specified by implementations of `Type`. These values are not used by the library and will be removed.
* It's not recommended to rely on the string representation of `Type` objects.
* Regular-expression based asset filters are deprecated in favor of callback-based as more extensible.
* Calling `Statement::fetchColumn()` with an invalid column index is deprecated.
* The `dbal:import` CLI command is deprecated. Please use other database client applications for import.

Please see details in the [UPGRADE.md](UPGRADE.md) documentation.

## New Features

* Added support for MariaDB 10.3.
* Added support for Windows authentication for SQL Server.
* Added support for column length in index definitions on MySQL.

## Improvements and Fixes

* Implemented handling BLOB objects represented as streams in the MySQL (`mysqli`) driver.
* Implemented handling BLOB objects represented as streams in the IDM DB2 driver.
* DBAL is now continuously tested with the PDO driver for Oracle.
* Implemented handling of URLs in master-slave and pooling-shard connection configuration.
* The codebase is now fully compatible with the Doctrine Coding Standard v5.0.

Total issues resolved: **45**

**Deprecations:**

- [3244: Deprecated dbal:import CLI command](doctrine#3244) thanks to @morozov
- [3253: Deprecated usage of the NULL offset in LIMITed queries](doctrine#3253) thanks to @morozov
- [3256: Deprecate Doctrine\DBAL\Types\Type::getDefaultLength()](doctrine#3256) thanks to @Majkl578
- [3258: Deprecate Doctrine\DBAL\Types\Type::&doctrine#95;&doctrine#95;toString()](doctrine#3258) thanks to @Majkl578
- [3316: Deprecated regex-based asset filters](doctrine#3316) thanks to @morozov
- [3359: Removed DataAccessTest::testFetchColumnNonExistingIndex() since it covers a bug in PDO](doctrine#3359) thanks to @morozov

**New Features:**

- [2412: Add mysql specific indexes with lengths](doctrine#2412) thanks to @bburnichon
- [3278: Add support for MariaDB 10.3](doctrine#3278) thanks to @javiereguiluz
- [3283: MariaDB improvements, support 10.3](doctrine#3283) thanks to @sidz
- [3333: Allow windows (userless/passwordless) authentication for SQL Server](doctrine#3333) thanks to @odinsey

**Bug Fixes:**

- [3355: Implemented comparison of default values as strings regardless of their PHP types](doctrine#3355) thanks to @morozov and @Majkl578

**Improvements:**

- [3201: Fix support for URL to account for master-slave and pooling-shard connections](doctrine#3201) thanks to @stof
- [3217: Fix that MysqliStatement cannot handle streams](doctrine#3217) thanks to @mpdude
- [3235: Use PSR-4 autoloader](doctrine#3235) thanks to @Majkl578
- [3254: Throw ConversionException when unserialization fail for array and object types](doctrine#3254) thanks to @seferov
- [3259: Update export ignores](doctrine#3259) thanks to @Majkl578
- [3309: Implemented handling BLOBs represented as stream resources for IBM DB2](doctrine#3309) thanks to @morozov and @mpdude
- [3331: Fetch all should use the driver statement's fetchAll method](doctrine#3331) thanks to @michaelcullum

**Documentation Improvements:**

- [3223: GitHub template grammar/spelling fixes](doctrine#3223) thanks to @GawainLynch
- [3232: Removed NOW() from QueryBuilder usage examples](doctrine#3232) thanks to @morozov
- [3239: 2.8 in README & branch alias to 2.9](doctrine#3239) thanks to @Majkl578
- [3269: Fixed type hints in DockBlocks](doctrine#3269) thanks to @marforon
- [3275: Add .doctrine-project.json to root of the project.](doctrine#3275) thanks to @jwage
- [3276: Update homepage](doctrine#3276) thanks to @Majkl578
- [3280: Use behaviuor instead of  behavior](doctrine#3280) thanks to @BackEndTea
- [3285: Remove old comment from MysqliStatement](doctrine#3285) thanks to @mpdude
- [3318: Removed link to www.doctrine-project.org from doc blocks](doctrine#3318) thanks to @morozov
- [3319: remove ClassLoader](doctrine#3319) thanks to @garak
- [3337: Fix of links in documentation](doctrine#3337) thanks to @SenseException
- [3350: Remove pdo&doctrine#95;sqlsrv from known vendor issues list](doctrine#3350) thanks to @ostrolucky
- [3357: Fix typo](doctrine#3357) thanks to @BenMorel
- [3370: Removed 2.7 from README](doctrine#3370) thanks to @morozov

**Code Quality Improvements:**

- [3252: Replaced call&doctrine#95;user&doctrine#95;func&doctrine#95;array() of a fixed method with the usage of variadic arguments](doctrine#3252) thanks to @morozov
- [3306: Fixed coding standard violations in the codebase](doctrine#3306) thanks to @morozov
- [3303: Updated doctrine/coding-standard to 5.0, ](doctrine#3303) thanks to @morozov
- [3317: Implemented proper escaping of string literals in platforms and schema managers](doctrine#3317) thanks to @morozov
- [3363: Remove redundant implements](doctrine#3363) thanks to @BenMorel

**Continuous Integration Improvements:**

- [3307: Test against the latest stable sqlsrv extension](doctrine#3307) thanks to @morozov
- [3320: Trying to fix failing DB builds](doctrine#3320) thanks to @morozov
- [3325: Updated PHPUnit to 7.4](doctrine#3325) thanks to @morozov
- [3339: ContinuousPHP configuration for PDO Oracle driver](doctrine#3339) thanks to @morozov
- [3365: Reorganize Travis build matrix](doctrine#3365) thanks to @BenMorel

# gpg: Signature made Tue Dec  4 05:44:06 2018
# gpg:                using RSA key 374EADAF543AE995
# gpg: Can't check signature: public key not found

# Conflicts:
#	README.md
#	lib/Doctrine/DBAL/Driver/AbstractOracleDriver.php
#	lib/Doctrine/DBAL/Version.php
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yguedidi yguedidi yguedidi approved these changes

@morozov morozov morozov approved these changes

Assignees

@morozov morozov

Labels
Configuration Improvement Sharding
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@stof @deguif @morozov @Majkl578 @Ocramius @yguedidi