Reorganize Travis build matrix #3365

BenMorel · 2018-11-29T15:44:41Z

Q	A
Type	improvement
BC Break	no
Fixed issues	N/A

This is a follow-up to #3347. This PR reorganizes the Travix CI matrix so that:

Every job is explicitly created via `jobs.include`

So far, a few jobs were created by a matrix created by the php and env configs, but most of them were excluded in jobs.exclude.

The php, env and jobs.exclude are now unnecessary, everything is explicitly listed in jobs.include.

Jobs are consistently ordered

PHP version
Driver
Platform version

Output can be automated

A script is available to generated the jobs matrix, respecting the points above and the algorithm suggested by @morozov in #3347:

the latest stable PHP version is tested against all drivers and platform versions, and used for code coverage analysis
other PHP versions are only tested against the latest version of the platform for each driver, with no code coverage

This PR should output the exact same Travis CI jobs as the latest master, in a different order.

BenMorel · 2018-11-29T15:55:33Z

This PR should output the exact same Travis CI jobs as the latest master, in a different order.

Note quite, time for some diffing again. Please stand by.

BenMorel · 2018-11-29T16:32:29Z

All good now. I forgot that:

DB=sqlite DEPENDENCIES=low|dev were not part of the script output
→ I reintroduced them manually after the automated script output
PHP=7.3|nightly DB=ibm_db2 fail and @morozov requested their exclusion from the build
→ I added a job exclusion configuration to the build script.

The jobs matrix is now the same as in the latest master, and correctly ordered. 👍

(at least in .travis.yml: Travis still moves a few jobs around from time to time.)

As requested by @morozov in #3347, I did not commit the script together with this PR. I, however, added a link to the script in .travis.yml, along with comments on where the automated script output starts and ends.

morozov

The end result looks lovely. Just a few nitpicks.

.travis.yml

morozov · 2018-11-30T19:10:42Z

LGTM. @BenMorel please squash.

Ocramius · 2018-11-30T21:41:18Z

.travis.yml

    - stage: Test
      php: 7.1
      env: DB=mysql MYSQL_VERSION=5.7
      sudo: required
      before_script:
        - bash ./tests/travis/install-mysql-5.7.sh
    - stage: Test
-      php: 7.2
-      env: DB=mysql MYSQL_VERSION=5.7 COVERAGE=yes
+      php: 7.1


7.1 was EOL'd today: @morozov what do we want to do about it, considered that the oatch targets master?

Let's drop it in 2.10. All changes in 2.9 were done considering PHP 7.1, so we don't have to drop it immediately.

BenMorel · 2018-12-01T00:15:01Z

Squashed!

morozov · 2018-12-01T00:27:10Z

Thank you, @BenMorel. Awesome work! I'll merge it as soon as the build finishes. Given that you have worked on the Travis config, maybe you might be interested in taking over #3122. If that's done, we could have much faster failures in case of non-platform specific issues and other violations like coding standards and PHPStan. In this case, you'd get feedback after running 1-3 jobs instead of ~50.

The challenge there is to make sure Scrutinizer code coverage collector adequately behave in the case when we don't run all build jobs but fail early. By default, it excepts to receive a predefined number of coverage reports.

@morozov

Release v2.9.0 This is a minor release of Doctrine DBAL that aggregates over 40 fixes and improvements developed by 18 contributors over the last 5 months. This release includes all changes of the 2.8.x series, as well as feature additions and improvements that couldn't land in patch releases. ## Backwards Compatibility Breaks This doesn't contain any intentional Backwards Compatibility (BC) breaks. ## Deprecations * The usage of `NULL` to specify the absence of an offset in `LIMIT`ed queries is deprecated. Use `0` instead. * It's not recommended to rely on the default length specified by implementations of `Type`. These values are not used by the library and will be removed. * It's not recommended to rely on the string representation of `Type` objects. * Regular-expression based asset filters are deprecated in favor of callback-based as more extensible. * Calling `Statement::fetchColumn()` with an invalid column index is deprecated. * The `dbal:import` CLI command is deprecated. Please use other database client applications for import. Please see details in the [UPGRADE.md](UPGRADE.md) documentation. ## New Features * Added support for MariaDB 10.3. * Added support for Windows authentication for SQL Server. * Added support for column length in index definitions on MySQL. ## Improvements and Fixes * Implemented handling BLOB objects represented as streams in the MySQL (`mysqli`) driver. * Implemented handling BLOB objects represented as streams in the IDM DB2 driver. * DBAL is now continuously tested with the PDO driver for Oracle. * Implemented handling of URLs in master-slave and pooling-shard connection configuration. * The codebase is now fully compatible with the Doctrine Coding Standard v5.0. Total issues resolved: **45** **Deprecations:** - [3244: Deprecated dbal:import CLI command](doctrine#3244) thanks to @morozov - [3253: Deprecated usage of the NULL offset in LIMITed queries](doctrine#3253) thanks to @morozov - [3256: Deprecate Doctrine\DBAL\Types\Type::getDefaultLength()](doctrine#3256) thanks to @Majkl578 - [3258: Deprecate Doctrine\DBAL\Types\Type::&doctrine#95;&doctrine#95;toString()](doctrine#3258) thanks to @Majkl578 - [3316: Deprecated regex-based asset filters](doctrine#3316) thanks to @morozov - [3359: Removed DataAccessTest::testFetchColumnNonExistingIndex() since it covers a bug in PDO](doctrine#3359) thanks to @morozov **New Features:** - [2412: Add mysql specific indexes with lengths](doctrine#2412) thanks to @bburnichon - [3278: Add support for MariaDB 10.3](doctrine#3278) thanks to @javiereguiluz - [3283: MariaDB improvements, support 10.3](doctrine#3283) thanks to @sidz - [3333: Allow windows (userless/passwordless) authentication for SQL Server](doctrine#3333) thanks to @odinsey **Bug Fixes:** - [3355: Implemented comparison of default values as strings regardless of their PHP types](doctrine#3355) thanks to @morozov and @Majkl578 **Improvements:** - [3201: Fix support for URL to account for master-slave and pooling-shard connections](doctrine#3201) thanks to @stof - [3217: Fix that MysqliStatement cannot handle streams](doctrine#3217) thanks to @mpdude - [3235: Use PSR-4 autoloader](doctrine#3235) thanks to @Majkl578 - [3254: Throw ConversionException when unserialization fail for array and object types](doctrine#3254) thanks to @seferov - [3259: Update export ignores](doctrine#3259) thanks to @Majkl578 - [3309: Implemented handling BLOBs represented as stream resources for IBM DB2](doctrine#3309) thanks to @morozov and @mpdude - [3331: Fetch all should use the driver statement's fetchAll method](doctrine#3331) thanks to @michaelcullum **Documentation Improvements:** - [3223: GitHub template grammar/spelling fixes](doctrine#3223) thanks to @GawainLynch - [3232: Removed NOW() from QueryBuilder usage examples](doctrine#3232) thanks to @morozov - [3239: 2.8 in README & branch alias to 2.9](doctrine#3239) thanks to @Majkl578 - [3269: Fixed type hints in DockBlocks](doctrine#3269) thanks to @marforon - [3275: Add .doctrine-project.json to root of the project.](doctrine#3275) thanks to @jwage - [3276: Update homepage](doctrine#3276) thanks to @Majkl578 - [3280: Use behaviuor instead of behavior](doctrine#3280) thanks to @BackEndTea - [3285: Remove old comment from MysqliStatement](doctrine#3285) thanks to @mpdude - [3318: Removed link to www.doctrine-project.org from doc blocks](doctrine#3318) thanks to @morozov - [3319: remove ClassLoader](doctrine#3319) thanks to @garak - [3337: Fix of links in documentation](doctrine#3337) thanks to @SenseException - [3350: Remove pdo&doctrine#95;sqlsrv from known vendor issues list](doctrine#3350) thanks to @ostrolucky - [3357: Fix typo](doctrine#3357) thanks to @BenMorel - [3370: Removed 2.7 from README](doctrine#3370) thanks to @morozov **Code Quality Improvements:** - [3252: Replaced call&doctrine#95;user&doctrine#95;func&doctrine#95;array() of a fixed method with the usage of variadic arguments](doctrine#3252) thanks to @morozov - [3306: Fixed coding standard violations in the codebase](doctrine#3306) thanks to @morozov - [3303: Updated doctrine/coding-standard to 5.0, ](doctrine#3303) thanks to @morozov - [3317: Implemented proper escaping of string literals in platforms and schema managers](doctrine#3317) thanks to @morozov - [3363: Remove redundant implements](doctrine#3363) thanks to @BenMorel **Continuous Integration Improvements:** - [3307: Test against the latest stable sqlsrv extension](doctrine#3307) thanks to @morozov - [3320: Trying to fix failing DB builds](doctrine#3320) thanks to @morozov - [3325: Updated PHPUnit to 7.4](doctrine#3325) thanks to @morozov - [3339: ContinuousPHP configuration for PDO Oracle driver](doctrine#3339) thanks to @morozov - [3365: Reorganize Travis build matrix](doctrine#3365) thanks to @BenMorel # gpg: Signature made Tue Dec 4 05:44:06 2018 # gpg: using RSA key 374EADAF543AE995 # gpg: Can't check signature: public key not found # Conflicts: # README.md # lib/Doctrine/DBAL/Driver/AbstractOracleDriver.php # lib/Doctrine/DBAL/Version.php

morozov reviewed Nov 29, 2018

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

Ocramius previously approved these changes Nov 30, 2018

View reviewed changes

morozov self-assigned this Nov 30, 2018

morozov added Improvement CI labels Nov 30, 2018

morozov added this to the 2.9.0 milestone Nov 30, 2018

Reorganize Travix build matrix

56845ae

BenMorel dismissed Ocramius’s stale review via 56845ae December 1, 2018 00:14

BenMorel force-pushed the travis_script branch from b9d9f91 to 56845ae Compare December 1, 2018 00:14

Ocramius changed the title ~~Reorganize Travix build matrix~~ Reorganize Travis build matrix Dec 1, 2018

morozov approved these changes Dec 1, 2018

View reviewed changes

morozov merged commit db2b846 into doctrine:master Dec 1, 2018

BenMorel mentioned this pull request Dec 1, 2018

Travis CI tests on MySQL 8.0 #3372

Merged

github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorganize Travis build matrix #3365

Reorganize Travis build matrix #3365

BenMorel commented Nov 29, 2018 •

edited

Loading

BenMorel commented Nov 29, 2018

BenMorel commented Nov 29, 2018

morozov left a comment

morozov commented Nov 30, 2018

Ocramius Nov 30, 2018

morozov Nov 30, 2018

BenMorel commented Dec 1, 2018

morozov commented Dec 1, 2018 •

edited

Loading

Reorganize Travis build matrix #3365

Reorganize Travis build matrix #3365

Conversation

BenMorel commented Nov 29, 2018 • edited Loading

Every job is explicitly created via jobs.include

Jobs are consistently ordered

Output can be automated

BenMorel commented Nov 29, 2018

BenMorel commented Nov 29, 2018

morozov left a comment

Choose a reason for hiding this comment

morozov commented Nov 30, 2018

Ocramius Nov 30, 2018

Choose a reason for hiding this comment

morozov Nov 30, 2018

Choose a reason for hiding this comment

BenMorel commented Dec 1, 2018

morozov commented Dec 1, 2018 • edited Loading

BenMorel commented Nov 29, 2018 •

edited

Loading

Every job is explicitly created via `jobs.include`

morozov commented Dec 1, 2018 •

edited

Loading