SQLSRV / MSSQL / TSQL - Fix default CLOB type from varchar(max) to nchar(max) & nvarchar(max) #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwitchell please add a test case which would fail without the fix. |
|
modifying this PR slightly as the library has lost the ability to accept a table as VARCHAR and allow you to keep the table as VARCHAR. Investigating whether an option 'is_unicode' or a unicodeStringType will solve this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modifies SQL Server (MSSQL, TSQL) VARCHAR column type to be NVARCHAR, to better handle unicode.
Initial breaking change: #451.