Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated CLOB type declaration in SQL Server platform #451

Conversation

deeky666
Copy link
Member

According to the SQL Server documentation the text type declaration is deprecated and will be removed in the future. It is encouraged to use varchar(max) instead. This has been applied to SQLServerPlatform::getClobTypeDeclarationSQL() by this PR.
The varchar(max) declaration is BC for all SQL Server versions supported by Doctrine btw.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-712

We use Jira to track the state of pull requests and the versions they got
included in.

@beberlei
Copy link
Member

@deeky666 Does SchemaManager detect VARCHAR(MAX) as text field compared to string?

@deeky666
Copy link
Member Author

@beberlei Yes the schema manager is implemented to do so. But I can add an explicit functional test for this if you want :)

@deeky666
Copy link
Member Author

As far as I remember textis internally mapped to varchar(max) by SQL Server anyway thus always retrieving varchar type from database with schema manager. I think I investigated once on how types are returned from DB and encountered this.

beberlei added a commit that referenced this pull request Dec 20, 2013
…type-declaration

Fix deprecated CLOB type declaration in SQL Server platform
@beberlei beberlei merged commit 6cd3df4 into doctrine:master Dec 20, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants