Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add varchar type #4269

Closed
wants to merge 606 commits into from
Closed

Add varchar type #4269

wants to merge 606 commits into from

Conversation

gjdanis
Copy link
Contributor

@gjdanis gjdanis commented Sep 11, 2020

Q A
Type improvement
BC Break no
Fixed issues #4263

Summary

Adds proper binding types per #4263.

@morozov
Added argument type declaration to MasterSlaveConnection::connect()
556c71d
@morozov
Removed never-reached code in tests
2f5a345
@morozov
Reworked unconditionally skipped tests
754d604
@morozov
Assert that the value is an array before accessing its elements
d3a3e01
@morozov
Merge branch '3.0.x'
ac0e13a
@morozov
Removed the hard-coded MySQL default port and the usage of ini-settings
8568ca6
@morozov
Removed EchoSQLLogger
d6f66d8
@morozov
Merge pull request doctrine#3934 from morozov/remove-echo-sql-logger
8d2aa41 
Removed EchoSQLLogger
@morozov
Merge pull request doctrine#3933 from morozov/remove-mysqli-default-port
66f0577 
Removed the hard-coded MySQL default port and the usage of ini-settings
@morozov
Enabled PHPStan strict rules
2b2848e
@morozov
Reworked type-based and conditions and clarified some types to justif…
4edcd15 
…y the ones that remain unchanged.
@morozov
Fixed dynamic calls to static methods
300a8e5
@morozov
Use the original case in method calls
8e4946a
@morozov
Reworked usages of the short ternary operator
f30a9a9
@morozov
Reworked all possible usages of the empty() construct and whitelisted…
6c4401f 
… the rest
@morozov
Avoid implicit conversion to boolean
7336ae0
@morozov
Suppressed variable property access error in statement classes
182d3d8
@morozov
Use in_array() in strict mode
24fc969
@morozov
Use array_search() in strict mode
8b0ddf6
@morozov
Anonymous function should have native return typehint
e17fcab
@morozov
Foreach overwrites $variable with its value variable.
2b3b718
@morozov
Use base64_decode() in strict mode
e676578
@morozov
Variable method call on an object
20c5931
@morozov
Reworked implicit array creation
7acf85c
@morozov
Fixed return values types to match the parent method types
d45fd7a
@morozov
Removed redundant casting to string
0a57e8e
@morozov
Only numeric types are allowed in +/-
559c6ba
@morozov
Declared Driver\Statement::bind(Parameter|Value) $name argument as st…
b8066db 
…ring|ing
@morozov
Merge pull request doctrine#3932 from morozov/phpstan-stricter
14f5f15 
Enable PHPStan strict rules
@morozov
Do not require hostname for non-persistent MySQL connection and requi…
b8a5cb2 
…re for persistent
morozov and others added 27 commits July 12, 2020 08:06
@morozov
Remove unnecessary method overrides in PrimaryReplicaConnection
684b4b5 
All removed methods are implemented via executeStatement() that ensures connection to the primary instance.
@morozov
Remove Connection::exec() and Connection::executeUpdate()
ea020aa
@morozov
Merge pull request doctrine#4167 from morozov/remove-wrapper-query-exec
4d17281 
Remove deprecated methods from the wrapper Connection
@morozov
Merge branch '2.11.x' into 3.0.x
4cc12da
@morozov
Add IdentityColumnsNotSupported exception
190a7af
@morozov
Merge branch '3.0.x'
40bbac9
@morozov
Merge branch '2.11.x' into 3.0.x
824d2eb
@morozov
Merge branch '3.0.x'
a36c5b7
@morozov
Merge branch '2.11.x' into 3.0.x
9eb0219
@morozov
Remove workaround in PDO\SQLSrv\Connection::quote()
95191ee
@morozov
Merge pull request doctrine#4192 from morozov/pdo-sqlsrv-quote
95b40a1 
Remove workaround in PDO\SQLSrv\Connection::quote()
@morozov
Merge branch '3.0.x'
859e80c
@morozov
Merge branch '2.11.x' into 3.0.x
e3231b4
@morozov
Remove --ignore-platform-reqs from PHP 8.0 builds
0d67274
@morozov
Merge pull request doctrine#4203 from morozov/issues/4200
aa848d8 
Remove --ignore-platform-reqs from PHP 8.0 builds
@morozov
Update locked composer/package-versions-deprecated
b49feb3
@morozov
Merge pull request doctrine#4207 from morozov/issues/4200
c70832a 
Update locked composer/package-versions-deprecated for compatibility with PHP 8.0
@morozov
Merge branch '3.0.x' into master
7441901
@morozov
Use empty string instead of NULL for mysqli SSL parameters by default
0112caa
@morozov
Revert the accidental rename of driverOptions to driver_options
f970697
@morozov
Merge branch '2.11.x' into 3.0.x
79c34f7
@morozov
Remove the Synchronizer package
4e53f63
@morozov
Merge pull request doctrine#4217 from morozov/remove-schema-synchronizer
66c17e2 
Remove the Synchronizer package
@morozov
Merge branch '3.0.x' into master
0dd84bf
@greg0ire
Merge remote-tracking branch 'origin/2.11.x' into 3.0.x
b2bd586
@greg0ire
Merge remote-tracking branch 'origin/3.0.x'
895e7d9
Initial commit
19fac52
@gjdanis gjdanis closed this Sep 11, 2020
@gjdanis gjdanis deleted the gdanis_add_varchar_type branch September 11, 2020 19:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gjdanis @morozov @greg0ire @dmaicher @nicolas-grekas @Majkl578 @jwage @ostrolucky