Fix MSSQL CLOB column type to support Unicode #4987
Conversation
mvorisek
force-pushed
the
fix_mssql_clob
branch
4 times, most recently
from
6e4fc34 to
e820ca0
Compare
mvorisek
force-pushed
the
fix_mssql_clob
branch
from
e820ca0 to
b9e3b49
Compare
|
It doesn't look like a bug so far. If it is, please provide the steps to reproduce and cover the change with an integration test. The mapping cannot be changed in a patch release, especially in |
why not? steps to replicate:
|
|
How are these steps related to Unicode? |
updated steps, previously, I posted steps for a different issue |
Where does it come from? |
|
where is the definition of |
| if ($doctrineType->getName() === Types::TEXT) { | ||
| // We require a commented text type in order to distinguish between text and string | ||
| // as both (have to) map to the same native type. | ||
| return true; |
There was a problem hiding this comment.
Only TEXT maps to VARCHAR(MAX). Is it possible to identify this during the schema introspection? See
dbal/src/Schema/SQLServerSchemaManager.php
Lines 80 to 86 in 5b456d8
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
non-stale |
|
About the upgrade path request, yes, the request is legit, but I have no time and experience to impl. it easily, thus I would like to keep this PR open for others to help with that. Thank you. |
Summary
VARCHARMSSQL type does not support Unicode, fix CLOB mapping toNVARCHAR. This is also consistent with standard string mapping which usesNVARCHARalready.