Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NVARCHAR to support unicode values in TEXT columns on SQLServer #5237

Closed
wants to merge 2 commits into from

Conversation

duncan3dc
Copy link
Contributor

@duncan3dc duncan3dc commented Feb 2, 2022

Q A
Type bug
BC Break yes
Fixed issues #2323 / #1351

Summary

When using the Doctrine type text some UTF-8 characters are converted to their ASCII equivalents. This PR uses a UTF-8 compatible column type to allow full support for UTF-8.

Requires #5236 & #5235 to be merged first

@morozov
Copy link
Member

morozov commented Feb 3, 2022

Looks like a duplicate of #4987.

@morozov
Copy link
Member

morozov commented Feb 3, 2022

I wouldn't consider this a bug. The DBAL supports Unicode to a certain extent but there's no definition of what that extent is. For instance, the recently merged #4855 was considered an improvement.

@morozov morozov removed the Bug label Feb 3, 2022
@duncan3dc duncan3dc closed this Feb 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants