Remove redundant method override

[duncan3dc]

Q	A
Type	improvement
BC Break	no

Summary

While investigating an issue I noticed this method overrides one that is identical, so this PR just removes the duplicate.

dbal/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php

Lines 1239 to 1242 in da4742c

	public function getClobTypeDeclarationSQL(array $column)
	{
	return 'VARCHAR(MAX)';
	}

[derrabus]

The change looks correct: the parent method does exactly the same. Not sure if it's worth merging this kind of change to 2.13.x though. On 3.3.x, this issue is fixed already.

[greg0ire]

It does not fall under any of the categories described in https://www.doctrine-project.org/2022/01/22/sunsetting-dbal-2.html, so let's close, sorry.

[duncan3dc]

It was cleanup in preparation for a bug fix (#5237) would you rather that bugfix was more complicated and updated two duplicate methods than merge this PR?

[derrabus]

We try to change as little as possible on the 2.13 branch. If a change does not fix a critical bug, we usually don't merge it anymore, especially if the problem was solved on a higher branch already.

[duncan3dc]

I don't understand the relevance of that sorry, are you saying you're rejecting the unicode/nvarchar bug fix for 2.13?

[derrabus]

No, I'm saying we're rejecting the change suggested in this PR.

[duncan3dc]

@greg0ire already said that, so then I asked if you'd rather the bugfix this is for (#5237) was more complicated, I'll presume that's a yes...