Use UTF-8 for SQLServer tests

[duncan3dc]

Q	A
Type	improvement
BC Break	no

Summary

While working on the fix for a bug around how UTF-8 data is handled I discovered that the default test connections to sqlserver are not using UTF-8. I couldn't find any tests that just configured this for them, so figured it should perhaps just be the default. If there's another preferred approach for this please let me know

[derrabus]

Can you have a look at the AppVeyor failure?

That being said, I wonder if it's worth fixing the 2.13 testsuite for that matter. Bugfixes should target the 3.3.x branch currently.

[derrabus]

Oh, I see why AppVeyor is broken. This is unrelated to your PR, nevermind.

[derrabus]

Can you please rebase on the latest 2.13.x branch? This should fix the AppVeyor build.

[morozov]

While working on the fix for a bug around how UTF-8 data is handled I discovered that the default test connections to sqlserver are not using UTF-8.

Why is this a problem? There is a test that runs SQL against different Unicode strings and passes:

dbal/tests/Functional/Platform/LengthExpressionTest.php

Lines 38 to 44 in 0dc504e

	public static function expressionProvider(): iterable
	{
	yield '1-byte' => ['Hello, world!', 13, false];
	yield '2-byte' => ['Привет, мир!', 12, true];
	yield '3-byte' => ['你好，世界', 5, true];
	yield '4-byte' => ['💩', 1, true];
	}

[duncan3dc]

Why is this a problem?

Without this, the test in #5237 fails:

1) Doctrine\Tests\DBAL\Functional\Platform\TextTypeTest::testAddColumnWithDefault
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
-    0 => 'Zażółć'
+    0 => 'Za?ó??'
 )

[morozov]

In this case, it should be part of the change that requires it. Note the 2.13.x is approaching the end of life, so this patch should be targeted at 3.4.x.

Note that the support for charset configuration in the test suite is already implemented in #4855.