-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SchemaIgnoreClasses property for #8195. #8203
Conversation
lib/Doctrine/ORM/Configuration.php
Outdated
* | ||
* @return string[] | ||
*/ | ||
public function getSchemaIgnoreClasses() : array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to make the naming a bit more precise, otherwise everything else is great. What do you think of get/setEntitiesIgnoredDuringSchemaGeneration
. I first thought it should be classes instead of entities, but embeddables and other non-entities are skipped already, so its really about skipping entities here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'm happy with that. Apologies for the delay, just committed the changes here so fingers crossed.
…eration to better reflect the purpose.
This feature would be very handy - is it just waiting approval? |
@mnkii :
|
I'll take a look in a few days and try and resolve the conflicts. I wasn't aware! |
Can I eventually help with it? Just run into the same need. |
@simPod you can sure open another PR targeting the right branch and fixing the conflicts 👍 |
@greg0ire is it 2.10? |
Yes, and the method to determine that is to take a look at the latest tag, then drop the patch number. |
Closing in favor of #9202. |
Thanks @simPod, I've been really busy recently. Much appreciated. |
Add schemaIgnoreClasses property, this list of entity classes is ignored by the schema tool when building a schema from metadata.
Fixes #8195