Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SchemaIgnoreClasses property for #8195. #8203

Closed
wants to merge 3 commits into from
Closed

Conversation

ianef
Copy link
Contributor

@ianef ianef commented Jul 7, 2020

Add schemaIgnoreClasses property, this list of entity classes is ignored by the schema tool when building a schema from metadata.

Fixes #8195

@beberlei beberlei linked an issue Jul 11, 2020 that may be closed by this pull request
*
* @return string[]
*/
public function getSchemaIgnoreClasses() : array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to make the naming a bit more precise, otherwise everything else is great. What do you think of get/setEntitiesIgnoredDuringSchemaGeneration. I first thought it should be classes instead of entities, but embeddables and other non-entities are skipped already, so its really about skipping entities here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm happy with that. Apologies for the delay, just committed the changes here so fingers crossed.

@mnkii
Copy link

mnkii commented Nov 4, 2021

This feature would be very handy - is it just waiting approval?

@greg0ire
Copy link
Member

greg0ire commented Nov 4, 2021

@mnkii :

  • Some checks haven't completed yet
  • This branch has conflicts that must be resolved

@ianef
Copy link
Contributor Author

ianef commented Nov 5, 2021

I'll take a look in a few days and try and resolve the conflicts. I wasn't aware!

@simPod
Copy link
Contributor

simPod commented Nov 24, 2021

Can I eventually help with it? Just run into the same need.

@greg0ire
Copy link
Member

@simPod you can sure open another PR targeting the right branch and fixing the conflicts 👍

@simPod
Copy link
Contributor

simPod commented Nov 24, 2021

@greg0ire is it 2.10?

@greg0ire
Copy link
Member

Yes, and the method to determine that is to take a look at the latest tag, then drop the patch number.

@derrabus
Copy link
Member

derrabus commented Dec 6, 2021

Closing in favor of #9202.

@derrabus derrabus closed this Dec 6, 2021
@ianef
Copy link
Contributor Author

ianef commented Dec 6, 2021

Thanks @simPod, I've been really busy recently. Much appreciated.

@ianef ianef deleted the 2.8.x branch December 6, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema exclude annotation
6 participants