Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SchemaIgnoreClasses property #9202

Merged
merged 1 commit into from
Dec 12, 2021
Merged

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Nov 24, 2021

Supersedes #8203
Fixes #8195

@simPod simPod marked this pull request as draft November 24, 2021 19:26
@simPod simPod force-pushed the exclude-entities branch 7 times, most recently from ebc75b7 to 9286540 Compare November 24, 2021 19:49
@simPod
Copy link
Contributor Author

simPod commented Nov 24, 2021

@greg0ire rebased, diff looks the same, CI is green. I guess it's k

@simPod simPod marked this pull request as ready for review November 24, 2021 19:52
@greg0ire
Copy link
Member

@simPod doesn't this require any documentation? Also, is it really a bugfix? Looks more like a new feature to me, in which case you should retarget to 2.11.x

@simPod
Copy link
Contributor Author

simPod commented Nov 24, 2021

It was already a feature in #8203 😄 I'll rebase and retarget then.

@simPod simPod marked this pull request as draft November 24, 2021 20:12
@simPod simPod changed the base branch from 2.10.x to 2.11.x November 24, 2021 21:22
@simPod simPod marked this pull request as ready for review November 24, 2021 21:22
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simPod simPod force-pushed the exclude-entities branch 2 times, most recently from 455be91 to 8822ee9 Compare November 26, 2021 08:04
Co-authored-by: Simon Podlipsky <simon@podlipsky.net>
@derrabus derrabus added this to the 2.11.0 milestone Dec 6, 2021
@derrabus derrabus changed the title Add SchemaIgnoreClasses property for #8195 vol 2 Add SchemaIgnoreClasses property Dec 6, 2021
@derrabus derrabus requested a review from beberlei December 6, 2021 00:20
@beberlei beberlei merged commit 4219506 into doctrine:2.11.x Dec 12, 2021
@beberlei
Copy link
Member

@simPod thanks!

@simPod simPod deleted the exclude-entities branch December 12, 2021 13:50
derrabus added a commit to derrabus/orm that referenced this pull request Dec 13, 2021
* 2.11.x:
  Deprecate Setup::registerAutoloadDirectory() (doctrine#9249)
  PHPCS 3.6.2, Psalm 4.15.0 (doctrine#9247)
  Add SchemaIgnoreClasses property for doctrine#8195. (doctrine#9202)
  Remove fallbacks for old doctrine/annotations version (doctrine#9235)
  Update docs/en/reference/events.rst
  Added psalm param to abstract addFilterConstraint (doctrine#9229)
  Merge pull request doctrine#9210 from alexander-schranz/patch-2
  Fix typo assumptio--> assumption
  Update events.rst
  Completing links to `EventArgs` classes in overview table
  Using `const` for `type`
  [Documentation] Events Overview Table: Adding "Passed Argument" column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants