-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove calls to prefersSequences() #8870
Remove calls to prefersSequences() #8870
Conversation
bbb909c
to
ca8b67b
Compare
ca8b67b
to
0abd654
Compare
4d06b88
to
1765c4c
Compare
Signed-off-by: Alexander M. Turek <me@derrabus.de>
1765c4c
to
edaa05a
Compare
I've pushed a new attempt, this time with special handling for Postgres and Oracle. Those were the only DBAL platforms that preferred sequences. Theoretically, this would still be a breaking change, if someone used a custom DBAL driver implementation (is this a thing?) that supports sequences and identity columns and prefers sequences. |
Thanks for mentioning that, it sounds pretty unlikely. |
Since there's an ongoing discussion in #8893, let's agree on something there first to make sure the changes here correspond to the agreement or explicitly agree that the discussion shouldn't hold the merge. Except for #8870 (comment), looks good to me. |
I'd say #8893 shouldn't hold the merge, these problems look independent to me. |
Thanks @derrabus ! |
AbstractPlatform::prefersSequences()
is deprecated and does not exist in DBAL 3. Let's not call it if it's not there.