Restore query() call for primary/replica connections
#9236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derrabus the (deprecated) UuidGenerator is also affected by the same issue (it was also using |
derrabus
force-pushed
the
bugfix/restore-query-on-primary-replica
branch
2 times, most recently
from
ce8f0d4 to
017fe6c
Compare
|
Fixed as well! |
derrabus
force-pushed
the
bugfix/restore-query-on-primary-replica
branch
3 times, most recently
from
02a58d6 to
e68094e
Compare
greg0ire
reviewed
Dec 11, 2021
greg0ire
previously approved these changes
Dec 11, 2021
|
I have an alternative here: #9239 |
stof
reviewed
Dec 13, 2021
derrabus
force-pushed
the
bugfix/restore-query-on-primary-replica
branch
from
3f159c5 to
479d586
Compare
|
@beberlei Your alternative targets 2.11. Shall we merge this PR anyway to fix the regression on 2.10? |
|
@derrabus the alternative version could be applied on 2.10 if that's the selected solution IMO. |
|
If we allow that kind of change in a bugfix release, okay. |
|
Closing in favor of #9239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On DBAL 2,
PrimaryReadReplicaConnection::query()executed the query on the primary connection. I broke the usage of this "hidden feature" while removing deprecated calls. This PR restores the functionality. At the same time, it removes mock logic that was supposed to catch my mistake but did not succeed doing so.