Make PrimaryReadReplicaConnection enforcement explicit #9239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized the primary also needs to be enforced when select statements are made with lock levels. This was a flaw previously too |
|
Actually, |
|
@beberlei should be done in 2.10.x IMO |
stof
reviewed
Dec 13, 2021
beberlei
force-pushed
the
PrimaryReplicaExplicit
branch
from
9fb5e61 to
de28ed2
Compare
beberlei
force-pushed
the
PrimaryReplicaExplicit
branch
from
de28ed2 to
fe2881c
Compare
stof
approved these changes
Dec 20, 2021
derrabus
changed the title
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 26, 2021
* 2.11.x: Enable UnusedUse sniff again (doctrine#9267) Whitelist composer plugins used by this repository (doctrine#9286) Fix XML export for `change-tracking-policy` (doctrine#9285) Allow symfony/cache 6 (doctrine#9283) Put actual value instead of index inside $originalEntityData. (doctrine#9244) Fix return types of cache interfaces (doctrine#9271) Better explain limitations of DQL "DELETE" (doctrine#9281) Fix docblocks on nullable EM properties (doctrine#9273) Docs: use canonical order for phpdoc tags, add missed semicolon (doctrine#9190) Make PrimaryReadReplicaConnection enforcement explicit (doctrine#9239) Regenerate Psalm baseline (doctrine#9272) Improve compatibility with Doctrine DBAL 4 (doctrine#9266) [docs] Fix wording for attributes=>parameters. (doctrine#9265) Support for nesting attributes with PHP 8.1 (doctrine#9241) Revert "Fix SchemaValidator with abstract child class in discriminator map (doctrine#9096)" (doctrine#9262) Docs: consistency for FQCN, spacing, etc (doctrine#9232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due a breaking API change with assumptions of
PrimaryReadReplicaConnectionin DBAL 3 without the distinction ofqueryandexecuteStatementit is required to address the use of primary replica connection more explicitly in ORM.This isn't the most pretty solution, but it detects the use of primary replica connection at the right points: 1. id generation 2. commit 3. DQL update/delete statements.