-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise progress bars on course page #4169
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
the
enhancement
A change that isn't substantial enough to be called a feature
label
Nov 17, 2022
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
November 17, 2022 09:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request optimizes the queries to load progress bars on the course page. This removes the need for partially loading the page as the slow elements are removed. All code for the partial load is thus also removed.
To optimize the queries I introduced an index. I also had to update the
judged
check for submission fromNOT IN
toIN
(With the list of statuses inverted). Without this change mysql refused to use the provided index.Replaces #4167
Below you can find the results of a speed comparison. For fair comparison I cleared my sql cache before each request. I tested on https://dodona.ugent.be/nl/courses/359/ which is a rather large course.
Closes #3962 .
Closes: #4167
PS: this pr also contained some changes to the generated database file.
This is probably caused by me having a backup of production on my machine.
I would keep these changes in as they reflect the state of the production database.