-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix series preview table height on the course page #4170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
November 17, 2022 15:36
bmesuere
requested changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with the index!
- When I deploy this on mestra, the series don't seem to load when they scroll into view (no errors in console, no requests are made).
- I'm not super fond of the difference in height for the skeleton bars. Is there a reason for that? The page grid looks nicer if they are all the same height heights (something in between the 2 heights that are used now)
|
chvp
approved these changes
Nov 22, 2022
bmesuere
approved these changes
Nov 22, 2022
Feels great to have this issue resolved. Thanks @jorg-vr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a third attempt to fix #3962. See #4167 and #4169 for previous attempts.
This pull request contains two parts:
Analysis
To analyze the impact of these changes, I looked at two large courses. For fair comparison I disabled memcached and the sql query cache.
http://dodona.ugent.be/nl/courses/800/
102 series | 640 exercises | 488 users | 491.449 submissions
http://dodona.ugent.be/nl/courses/359/
22 series | 90 exercises | 623 users | 355.789 submissions
Notes
The speed up is much less noticeable for the first course. This is due to the first two series of that course being exams in which few students participated.
In the second course the speedup is much greater then the slowdown, caused by loading the activity names.
In order to limit the increase in file size, I tried to keep the amount of html for each row to a minimum.
Visual
Old
New
Closes #3962 .
PS: this pr also containes some changes to the generated database file.
This is probably caused by me having a backup of production on my machine.
I would keep these changes in as they reflect the state of the production database.