Add export of course users #5411
Conversation
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
There was a problem hiding this comment.
I agree with the export-related code changes and the fact that we make this more prominent, but I'm not convinced that the overflow menu of the search bar is the right place to put those options. They are still hidden and I would never check that menu.
Can we add figure out another way to place these actions? Maybe right-aligned buttons (but that might not be possible on smaller screens)?
| format.js do | ||
| @course_memberships = @course_memberships.paginate(page: parse_pagination_param(params[:page])) | ||
| end | ||
| format.csv do |
There was a problem hiding this comment.
The x_sendfile setting isn't present here (and was in the old code). Is this something that isn't needed anymore?
There was a problem hiding this comment.
"X-Sendfile is a special header option that tells the web server to ignore the content of the response and replace it by the file that is specified in the X-Sendfile header."
This is not relevant in this case, as the response is now the actual csv
This pull request adds an export of all users in a course.
The csv is a different content type for the index api endpoint.
This means that all filters and sort features of the index page can also be applied.
The export now also includes the student progress in the course.
This export also replaces the old specific export labels csv, in the edit all labels flow.
Closes #3617