-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make search actions and options more discoverable #5430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a step in the right direction, but I'm not entirely convinced yet.
- If we group the filter settings, we need a better word for "options"
- To me, auto refresh is not a filter so it doesn't belong there
- The actions now look very similar to filters. The only difference is the left vs. right alignment. I feel like this is not enough.
Sorry for not coming up with alternatives myself right now.
Ok I've tried some different styles for the action buttons Of these options I still prefer the outline buttons. A case can be made to give the accept all and decline all a success and danger color. But that doesn't fix the general problem of styling the action buttons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try making the filter dropdowns more chip-like: https://m3.material.io/components/chips/accessibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request moves the search actions to actual buttons with text.
This makes them more discoverable.
To achieve this I split up 'options' and 'actions', which also improves the code.
Options have also been simplified, as they were always used to set a single variable to true or false.
I also updated course tabs to make use of the existing search_tab component. This allowed me to get rid of some custom js in course.ts that interacted with actions which should only be shown on a specific tab.
This pr also contains a minor bugfix for the loading bar, which I noticed while working on this.
To make the actions sufficiently different from the existing dropdowns, the dropdowns have been redesigned:
Actions for course members
Actions for solutions
Fixes #5411 (review)