Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search actions and options more discoverable #5430

Merged
merged 16 commits into from
Apr 22, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Mar 12, 2024

This pull request moves the search actions to actual buttons with text.
This makes them more discoverable.

To achieve this I split up 'options' and 'actions', which also improves the code.
Options have also been simplified, as they were always used to set a single variable to true or false.

I also updated course tabs to make use of the existing search_tab component. This allowed me to get rid of some custom js in course.ts that interacted with actions which should only be shown on a specific tab.

This pr also contains a minor bugfix for the loading bar, which I noticed while working on this.

To make the actions sufficiently different from the existing dropdowns, the dropdowns have been redesigned:
image

Actions for course members
image
image

Actions for solutions
image

  • Tests were added

Fixes #5411 (review)

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Mar 12, 2024
@jorg-vr jorg-vr self-assigned this Mar 12, 2024
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Mar 12, 2024

Maybe an idea for the scoresheet to make the series option a dropdown filter and the download button a search action.

This would win some vertical space
image

@jorg-vr jorg-vr marked this pull request as ready for review March 12, 2024 16:39
@jorg-vr jorg-vr requested a review from a team as a code owner March 12, 2024 16:39
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team March 12, 2024 16:39
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a step in the right direction, but I'm not entirely convinced yet.

  • If we group the filter settings, we need a better word for "options"
  • To me, auto refresh is not a filter so it doesn't belong there
  • The actions now look very similar to filters. The only difference is the left vs. right alignment. I feel like this is not enough.

Sorry for not coming up with alternatives myself right now.

@jorg-vr jorg-vr marked this pull request as draft March 27, 2024 08:41
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Mar 27, 2024

Ok I've tried some different styles for the action buttons

Outline

image
image
image
image
image
image

Tonal

image
image
image
image
image
image

Filled

image
image
image
image
image
image

Secondary outline

image
image
image
image
image
image

No outline for dropdowns

image
image
image

Of these options I still prefer the outline buttons.
Tonal buttons look okay in light mode, but way to prominent in dark mode. The opposite can be said for filled buttons.

A case can be made to give the accept all and decline all a success and danger color. But that doesn't fix the general problem of styling the action buttons.

Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try making the filter dropdowns more chip-like: https://m3.material.io/components/chips/accessibility

@jorg-vr jorg-vr marked this pull request as ready for review April 3, 2024 14:46
@jorg-vr jorg-vr requested a review from bmesuere April 3, 2024 14:46
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Apr 20, 2024
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

They can use a bit of vertical padding when they use multiple lines:
image

@jorg-vr jorg-vr merged commit 11e4aee into main Apr 22, 2024
12 of 13 checks passed
@jorg-vr jorg-vr deleted the enhance/search-action-discoverability branch April 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy mestra Request a deployment on mestra enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants