Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3d9] Implement rudimentary device loss #3316

Merged
merged 2 commits into from
May 3, 2023

Conversation

K0bin
Copy link
Collaborator

@K0bin K0bin commented Mar 27, 2023

I hate that we have to do this but:

Fixes #3314

It's hidden behind a config option because pretty much all games work fine without it and enabling it would just cause unnecessary work for those games.

Aside from DC Online, I enabled it for GTA IV because that game also has a ton of issues with alt-tab. Maybe we'll get lucky and these changes finally fix it.

@K0bin K0bin force-pushed the device-lost branch 2 times, most recently from 8a0df43 to 7c68ff5 Compare March 27, 2023 20:09
@K0bin K0bin requested a review from misyltoad March 27, 2023 20:10
@K0bin K0bin added the d3d9 label Mar 27, 2023
@K0bin K0bin force-pushed the device-lost branch 3 times, most recently from a0c2bc9 to 3c18dce Compare March 27, 2023 22:55
@K0bin
Copy link
Collaborator Author

K0bin commented Mar 27, 2023

@Joshua-Ashton This is ready for a review now.

Copy link
Collaborator

@misyltoad misyltoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit.

Not as bad as I thought it'd be...

Probably worth also hard disabling this for 9Ex devices as we may have games with a launcher that mix and match here or whatever.

src/d3d9/d3d9_device.cpp Outdated Show resolved Hide resolved
@misyltoad misyltoad merged commit b357d16 into doitsujin:master May 3, 2023
@K0bin K0bin deleted the device-lost branch May 3, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DC Universe Online alt tab render freeze
2 participants