Fix crash when srv is submitted to ClearUnorderedAccessViewUint #3734
Conversation
…ccessViewUint. The static_cast in the function does not translate correctly and crashes. Native D3D11 behavior is to ignore the bad parameter entirely. It does not clear the SRV nor does it fault or even error with the DEBUG validator. This QI confirms that it is in fact a UAV that is passed in, emulating the native D3D11 behavior.
|
Can we do something other than QueryInterface here which involves useless atomic ref-ing? Do we have a base class for views we can grab some type enum from? |
Integrate feedback
|
@Joshua-Ashton , I don't know dxvk well enough to suggest something that would pass muster here. Frankly though, seems like premature optimization when QI is the correct and expected behavior in all other such instances. |
|
QI is fine, it's not like games call ClearUAV more than a dozen times or so per frame. My real issue here is that passing an SRV by accident shouldn't even be possible, the parameter is typed after all and only accepts a UAV pointer. The only way this can even happen is if the game deliberately and knowingly casts a non-UAV pointer to UAV. |
|
@doitsujin , completely agreed, which is why I provided the native sample showing the behavior Microsoft has implemented, no doubt earned in blood. :-) |
The Settlers: New Allies, crashes on launch due to the fact that it tries to submit an SRV to clearance via ClearUnorderedAccessViewUint.
The native behavior is to ignore the errant resource type (see attached repro of the behavior) but dxvk, due to a static cast, crashes when it references the mis-cast object. This change does a QI and confirms the correct object before use, returning immediately if it is not.
D3D11SrvClearTest.cpp