Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when srv is submitted to ClearUnorderedAccessViewUint #3734

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fix crash when srv is submitted to ClearUnorderedAccessViewUint #3734

merged 2 commits into from
Jan 23, 2024

Commits on Dec 5, 2023

  1. The Settlers submits (possibly incorrectly) an SRV to ClearUnorderedA… 

    …ccessViewUint. The static_cast in the function does not translate correctly and crashes.

Native D3D11 behavior is to ignore the bad parameter entirely. It does not clear the SRV nor does it fault or even error with the DEBUG validator.

This QI confirms that it is in fact a UAV that is passed in, emulating the native D3D11 behavior.
    @canadacow
    canadacow committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    aad6b36 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Update d3d11_context.cpp 

    Integrate feedback
    @canadacow
    canadacow authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    47c5bc4 View commit details
    Browse the repository at this point in the history