Replace http-server with serve #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwistrand
approved these changes
May 2, 2019
|
For what it's worth, |
agubler
force-pushed
the
remove-http-server
branch
from
c75295d to
92e3200
Compare
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=======================================
Coverage 51.39% 51.39%
=======================================
Files 10 10
Lines 646 646
Branches 168 168
=======================================
Hits 332 332
Misses 314 314Continue to review full report at Codecov.
|
matt-gadd
approved these changes
May 22, 2019
agubler
added a commit
to agubler/cli-build-app
that referenced
this pull request
Jun 18, 2019
* Replace http-server with serve * Update node version to 10 for CI * Add slash to tests * Upgrade cypress
3 tasks
agubler
added a commit
that referenced
this pull request
Jun 18, 2019
* Replace http-server with serve (#271) * Replace http-server with serve * Update node version to 10 for CI * Add slash to tests * Upgrade cypress * fix caniuselite version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettierDescription:
Replaces
http-serverwithserveand updates towebpack-contrib@5.0.2Resolves #270
Depends on a release containing dojo/webpack-contrib#142