Backport vuln fix to major version 3 #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Obviously can't merge to master - we'd need a different target branch to release this through. |
|
@jfhbrook could make a |
This was referenced May 2, 2019
Closed
thornjad
approved these changes
May 2, 2019
BigBlueHat
approved these changes
May 2, 2019
3 tasks
|
instead of waiting around, i suppose there's no harm in anybody temporarily publishing |
This was referenced May 2, 2019
skalyanmoguloju
approved these changes
May 2, 2019
|
I can push this out tomorrow morning. |
pancelor
added a commit
to pancelor/sokosoko
that referenced
this pull request
May 3, 2019
edit: ooooof it's slow I'd like to switch to npm's http-server: https://stackoverflow.com/questions/12905426/what-is-a-faster-alternative-to-pythons-http-server-or-simplehttpserver https://www.npmjs.com/package/http-server but there's a dep error right now b/c of a security thing with a dep. See also http-party/http-server#521 jfhbrook/node-ecstatic#256 (comment)
|
Rather than trying to pull down this branch I just replayed your steps. The result is published as 3.3.2. Cheers! |
|
@jfhbrook Awesome, thanks bud! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked the patch commit that resolved the Open Redirect vulnerability announced.