Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect out of date features #145

Closed
alandtse opened this issue Nov 21, 2023 · 2 comments · Fixed by #180
Closed

Detect out of date features #145

alandtse opened this issue Nov 21, 2023 · 2 comments · Fixed by #180
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alandtse
Copy link
Collaborator

We should detect out of date features and provide a warning to users. All features are currently versioned. The simplest would be to requires the latest version and up when a new base CS is released. Features currently do not strictly follow semver so we may want to do that moving forward. I.e., the major version increments if it would break on older CS versions.
@alandtse alandtse added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 21, 2023
@Pentalimbed
Copy link
Collaborator

STL::Version could be a good starting point. Although currently it can only convert version strings delimited by . not -. And it has 4 numbers.

@alandtse
Copy link
Collaborator Author

alandtse commented Feb 2, 2024

It's a very simple regex to do a conversion so that may be the way to go. The main issue is someone committing the time.

FlayaN added a commit to FlayaN/skyrim-community-shaders that referenced this issue Feb 10, 2024
@FlayaN
feat: Added feature version detection
e3e8deb 
fix doodlum#145
FlayaN added a commit to FlayaN/skyrim-community-shaders that referenced this issue Feb 10, 2024
@FlayaN
feat: Added feature version detection
ad81e73 
fix doodlum#145

---------
Co-authored-by: Andersw88 <anders.wikstrom.88@gmail.com>
@FlayaN FlayaN mentioned this issue Feb 10, 2024
Merged
FlayaN added a commit to FlayaN/skyrim-community-shaders that referenced this issue Feb 14, 2024
@FlayaN
feat: Added feature version detection
2999950 
fix doodlum#145

---------
Co-authored-by: Andersw88 <anders.wikstrom.88@gmail.com>
FlayaN added a commit to FlayaN/skyrim-community-shaders that referenced this issue Feb 20, 2024
@FlayaN
feat: Added feature version detection
36f351a 
fix doodlum#145

---------
Co-authored-by: Andersw88 <anders.wikstrom.88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add feature version detection FlayaN/skyrim-community-shaders
2 participants
@alandtse @Pentalimbed