Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skyrim exe hangs and cannot exit on game close #296

Closed
alandtse opened this issue Apr 28, 2024 · 2 comments · Fixed by #313 or #464
Closed

Skyrim exe hangs and cannot exit on game close #296

alandtse opened this issue Apr 28, 2024 · 2 comments · Fixed by #313 or #464
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alandtse
Copy link
Collaborator

On a vanilla Skyrim setup, Community shaders ends up in a deadlock with the threadpool with an active task that refuses to close. This requires killing the process in taskmanager.

It may be a shader task that failed and isn't being cleaned up. I've disabled the filewatcher queuing in code and still get the impact. It may be related to the bug where FXAA IS started trying to be compiled.
@alandtse alandtse added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Apr 28, 2024
@alandtse
Copy link
Collaborator Author

Ok, when I have a full load order, I don't run into this.

@alandtse
Copy link
Collaborator Author

alandtse commented May 7, 2024

We're stuck waiting on a stuck thread in https://github.com/bshoshany/thread-pool. This behavior remains even when updating to the latest version (which introduced a API change).

alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue May 25, 2024
@alandtse
fix: fix Skyrim hanging on exit
e9ff1bf 
Adds more explicit checks for cache stop_token message and also includes
a thread killing function if it has not stopped cleanly.

closes doodlum#296
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue May 25, 2024
@alandtse
fix: fix Skyrim hanging on exit
d110484 
Adds more explicit checks for cache stop_token message and also includes
a thread killing function if it has not stopped cleanly.

closes doodlum#296
@alandtse alandtse mentioned this issue May 25, 2024
Merged
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue May 25, 2024
@alandtse
fix: fix Skyrim hanging on exit
dbde117 
Adds more explicit checks for cache stop_token message and also includes
a thread killing function if it has not stopped cleanly.

closes doodlum#296
@alandtse alandtse reopened this Aug 26, 2024
@alandtse alandtse mentioned this issue Aug 26, 2024
Closed
55 tasks
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Aug 26, 2024
@alandtse
fix: kill management thread on stop
48e1897 
closes doodlum#296
@alandtse alandtse mentioned this issue Aug 26, 2024
Merged
doodlum pushed a commit that referenced this issue Aug 26, 2024
@alandtse
fix: kill management thread on stop (#464)
d7d5ff3 
closes #296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
1 participant
@alandtse