Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Feature loading code #97

Closed
3 of 4 tasks
alandtse opened this issue Sep 18, 2023 · 4 comments
Closed
3 of 4 tasks

Simplify Feature loading code #97

alandtse opened this issue Sep 18, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alandtse
Copy link
Collaborator

alandtse commented Sep 18, 2023

There's certain inefficiencies in the feature loading that requires a lot of duplicated code.

At least for the loading section, we could require all features implement a function to call (could be blank). So DataLoaded, PostPostLoad, etc.

@alandtse alandtse added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 18, 2023
@FlayaN
Copy link
Collaborator

FlayaN commented Oct 1, 2023

Can check 2-4 now with my PR, if dev branch is enough. Also added wiki documentation for the virtual functions in Feature.h https://github.com/doodlum/skyrim-community-shaders/wiki/Developers#virtual-functions

@Pentalimbed
Copy link
Collaborator

  • Manual registration for the feature vectors

I don't think there is a better way to approach this. You have to reference the class itself at some place, and it cannot really be simpler than the current two (or three) lines: one include, one or two singleton calls.

@FlayaN
Copy link
Collaborator

FlayaN commented Feb 7, 2024

Yeah that's why I only did 2-4. Didn't think of an nice way to finish

Manual registration for the feature vectors

Is there more details on how that can be improved? Otherwise I guess this task can be closed

@alandtse
Copy link
Collaborator Author

alandtse commented Feb 8, 2024

I'm ok with closing if we think we've done enough. Or this can just go stale in the hope someone surprises us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants