feat: simplify feature loading #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alandtse
approved these changes
Oct 1, 2023
|
Ah gotcha! Do you think I should include the drawdeferred or not? Due to it not being called yet |
|
Fine to include. We can PR the features to use it when they come in. |
|
Nice, I'll update the wiki as soon as this is merged then! |
alandtse
added a commit
to alandtse/skyrim-community-shaders
that referenced
this pull request
Oct 4, 2023
Required by doodlum#115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify feature loading by adding optional virtual functions in Feature.h that can be overriden by features. This will reduce the need to modify State.cpp, XSEPlugin.cpp & Menu.cpp when adding new features etc
Added to
Feature.h:DataLoaded<-- Called by SKSEkDataLoadedeventPostPostLoad<-- Called by SKSEkPostPostLoadeventClearShaderCache<-- Called by imgui clear shader cache buttonDrawDeferred<-- This one is not called yet, that is in the subsurface-scattering branchFixed almost all tasks of #97
Link to build for this PR -> https://github.com/FlayaN/skyrim-community-shaders/releases/tag/untagged-626eeecf0c4665d55ff6
Created this as a draft due to this should maybe wait until subsurface-scattering is in dev (Or maybe remove the DrawDeferred part of the PR), would like some feedback if this is what you meant on your issue @alandtse