Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LLF support to effect and waters shaders #152

Merged
merged 10 commits into from
Jan 8, 2024
Merged

Conversation

doodlum
Copy link
Owner

@doodlum doodlum commented Jan 8, 2024

  • Effect shaders should work 1:1 compared to vanilla
  • Water shaders should work differently, since they have access to high quality normal maps. I found that vanilla water specularity is way too bright, so I've darkened it to match the new lighting on non-strict portal lights. Might improve performance vs vanilla because it reduces draw calls on water.
  • VR is detected so that these flatrim-specific changes should not affect it.
  • Some shadercache code has been refactored to be accessible elsewhere.

Copy link
Collaborator

@alandtse alandtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to bump the version too? Or do you want to do it separately because of other prs?

@alandtse alandtse changed the title feat: added LLF support to effect and waters shaders feat: add LLF support to effect and waters shaders Jan 8, 2024
@doodlum
Copy link
Owner Author

doodlum commented Jan 8, 2024

Do you need to bump the version too? Or do you want to do it separately because of other prs?

I'll deal with it when checking what features changed since the last set of releases.

@doodlum doodlum merged commit 0697056 into dev Jan 8, 2024
@doodlum doodlum deleted the llf-extensions branch January 8, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants