-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add LLF support to effect and waters shaders #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
doodlum
commented
Jan 8, 2024
- Effect shaders should work 1:1 compared to vanilla
- Water shaders should work differently, since they have access to high quality normal maps. I found that vanilla water specularity is way too bright, so I've darkened it to match the new lighting on non-strict portal lights. Might improve performance vs vanilla because it reduces draw calls on water.
- VR is detected so that these flatrim-specific changes should not affect it.
- Some shadercache code has been refactored to be accessible elsewhere.
alandtse
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to bump the version too? Or do you want to do it separately because of other prs?
alandtse
changed the title
feat: added LLF support to effect and waters shaders
feat: add LLF support to effect and waters shaders
Jan 8, 2024
I'll deal with it when checking what features changed since the last set of releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.