feat: add VR water shader #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alandtse
force-pushed
the
VR_water
branch
4 times, most recently
from
4eeffcd to
12c332d
Compare
alandtse
force-pushed
the
VR_water
branch
8 times, most recently
from
3dc7d6d to
60efd48
Compare
alandtse
commented
Mar 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Caustic bugs fixed. Others are leftover from flat so no further work for now. |
NOTE: There are still bugs.
This is still broken as water at Lake Illinata `coc guardianstones` is fully transparent. But at least it doesn't move with HMD.
This reverts commit c31be87.
Moving water specific function to water.hlsl.
FlayaN
reviewed
Apr 4, 2024
FlayaN
reviewed
Apr 4, 2024
|
Ok, new report. Moving headset up and down results in caustics moving up and down; see pools in whiterun. Moving back to draft. I'll probably not work on this for a bit so will let someone else finish it.
|
In VR, the texture is all black.
The #ifdef Water complicates the code more than is probably needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables water blending, parallax, etc.
Awaiting discord testing.
https://discord.com/channels/1080142797870485606/1082470343119216751/1224281708590010432