feat: add perfevent and marker flags #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlayaN
force-pushed
the
add-perf-event-and-marker
branch
from
84a1990 to
ec8d7c7
Compare
alandtse
reviewed
Apr 2, 2024
| if (vertexShader && pixelShader) { | ||
| for (auto* feature : Feature::GetFeatureList()) { | ||
| if (feature->loaded) { | ||
| auto hasShaderDefine = feature->HasShaderDefine(currentShader->shaderType.get()); | ||
| if (hasShaderDefine) | ||
| BeginPerfEvent(feature->GetShortName()); |
There was a problem hiding this comment.
Just a comment that we'll want to do this for deferred too when merged.
alandtse
approved these changes
Apr 2, 2024
alandtse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds event around feature drawing (and explicitly added support for SSS)
Only adds the marker in development mode. Due to getting define will take a bit.
Also added marker for showing the DEFINES under the first event level
Examples in NSight.
