Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix VR #328

Merged
merged 20 commits into from
Jul 9, 2024
Merged

fix: fix VR #328

merged 20 commits into from
Jul 9, 2024

Conversation

FlayaN
Copy link
Collaborator

@FlayaN FlayaN commented Jul 4, 2024 •
edited by alandtse
Loading

Fixed the offsets I could find, also added a VR check if the user have the correct vr-address-library version

These offsets have all been verified in IDA

Draft until vr-address-library is updated with the new id 524768 Added in vr-address-library 0.140.0

closes #331

Added VR support to these features:

  • Cloud shadows
  • Skylighting
  • Terrain Blending

@alandtse
Copy link
Collaborator

alandtse commented Jul 4, 2024

Should be just a fix not feat.

@FlayaN FlayaN changed the title feat: fix VR offsets fix: fix VR offsets Jul 4, 2024
@FlayaN FlayaN changed the title fix: fix VR offsets fix: fix VR offsets and GetRuntimeData Jul 5, 2024
FlayaN
FlayaN commented Jul 6, 2024
View reviewed changes
src/XSEPlugin.cpp Outdated Show resolved Hide resolved
FlayaN
FlayaN commented Jul 6, 2024
View reviewed changes
extern/CommonLibSSE-NG Outdated Show resolved Hide resolved
@FlayaN FlayaN marked this pull request as ready for review July 6, 2024 09:43
@FlayaN
Copy link
Collaborator Author

FlayaN commented Jul 6, 2024 •
edited
Loading

Getting these error while compiling shaders:
Data\Shaders\Lighting.hlsl(1507,19-91): error X3004: undeclared identifier 'GetSkylightOcclusion' Fixed

If having sky shader enabled:
Failed to compile Pixel shader Sky::0: Common/VR.hlsli(6,8-21): error X3003: redefinition of 'AlphaTestRefRS'

@FlayaN FlayaN marked this pull request as draft July 6, 2024 14:35
@FlayaN FlayaN marked this pull request as ready for review July 6, 2024 14:36
@FlayaN FlayaN marked this pull request as draft July 6, 2024 16:58
@FlayaN
Copy link
Collaborator Author

FlayaN commented Jul 6, 2024 •
edited
Loading

Might have a fix for the "everything being dark issue" Yep, fixed in last commit

@FlayaN FlayaN marked this pull request as ready for review July 6, 2024 17:03
@alandtse alandtse mentioned this pull request Jul 7, 2024
Closed
6 tasks
alandtse added 4 commits July 7, 2024 00:45
@alandtse
fix: fix water rendering
9ada13e
@alandtse
fix(VR): fix screen space shadows
58e3e55 
Fix loading of ScreenSpaceShadowsTexture stereo buffer using a non
stereo uv coordinate.
@alandtse
fix: fix bad uv conversion
3b478a7 
Typically dtid is in stereo so needs to be corrected to nonstereo.
@alandtse
feat(VR): enable sky and cloud shadows
35c4192
@FlayaN FlayaN changed the title fix: fix VR offsets and GetRuntimeData fix: fix VR Jul 7, 2024
doodlum and others added 3 commits July 7, 2024 17:36
@doodlum @alandtse
fix: incorrect reflections
096d5db
@alandtse
feat: add particle shader
c25c931
@alandtse
feat: add bloodsplatter shader
1ffc047 
VR and Flat look identical in RE. With this we have parity across both.
@doodlum doodlum merged commit 0339516 into doodlum:dev Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alandtse alandtse alandtse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VR issues in dev
3 participants
@FlayaN @alandtse @doodlum