Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up dynamic resolution utils #344

Merged

Conversation

FlayaN
Copy link
Collaborator

@FlayaN FlayaN commented Jul 18, 2024

Updated to latest CommonLibSSE-NG and updated related dynamic resolution names

HLSL:

  • Added a ConvertUVToSampleCoord method to make it easier to load from a stereo texture with dynamic resolution
    • Usage: Texture.Load(ConvertUVToSampleCoord(uv, eyeIndex)) instead of having to convert uv to stereo and multiply with BufferDim and dynamic scaling

CPP:

  • Added a ConvertToDynamic method to Util to convert a size to support dynamic resolution
  • Use GetScreenDispatchCount for SubsurfaceScattering due to it having the same resolution as the main texture anyway. So same resolution, so cleaner to use GetScreenDispatchCount Util
  • Converted float screenWidth and float screenHeight to float2 screenSize in State to use it with utils easier

@FlayaN FlayaN force-pushed the refactor-clean-up-dynamic-resolution-utils branch from b44f75b to 13b04f6 Compare July 18, 2024 11:56
@FlayaN FlayaN force-pushed the refactor-clean-up-dynamic-resolution-utils branch from 13b04f6 to 46832eb Compare July 18, 2024 17:32
@doodlum doodlum merged commit 45456de into doodlum:dev Jul 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants