Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: imagespace shaders support. #359

Merged
merged 22 commits into from
Aug 4, 2024
Merged

Conversation

Jonahex
Copy link
Collaborator

@Jonahex Jonahex commented Jul 28, 2024

Shader cache support for imagespace shaders and some shaders REd. Missing shaders:

  • ISApplyVolumetricLighting
  • ISFXAA
  • ISReflectionsRayTracing
  • ISSAOBlur
  • ISSAOCameraZ
  • ISSAOComposite
  • ISSAORawAO
  • ISSILComposite
  • ISSILRawInd
  • ISSnowSSS
  • ISTemporalAA
  • ISUnderwaterMask
  • LensFlare

Compute shaders also lack all of supporting code. Missing compute shaders:

  • ISBlurCS
  • ISCopySubRegionCS
  • ISDownsampleCS
  • ISPerlinNoiseCS
  • ISSAOBlurCS
  • ISSAOCameraZAndMipsCS
  • ISSAORawAOCS
  • ISVolumetricLightingGenerateCS
  • ISVolumetricLightingRaymarchCS

Shaders are not adapted for VR. Missing VR-only shaders:

  • ISDownsampleHierarchicalDepthBufferCS
  • ISFullScreenVR
  • ISPreTestDepthBufferCullingCS

Requires alandtse/CommonLibVR#55

@doodlum
Copy link
Owner

doodlum commented Jul 28, 2024

Would need to know if this doesn't break VR, as well as wait on the CommonLib PR.

Shouldn't the fog composite be listed as missing too?

@Jonahex
Copy link
Collaborator Author

Jonahex commented Jul 29, 2024

Would need to know if this doesn't break VR

Imagespace shaders are disabled in VR in this PR

@Jonahex
Copy link
Collaborator Author

Jonahex commented Jul 29, 2024

Shouldn't the fog composite be listed as missing too?

ISSAOCompositeFog? It's part of ISSAOComposite

@doodlum
Copy link
Owner

doodlum commented Jul 29, 2024

Shouldn't the fog composite be listed as missing too?

ISSAOCompositeFog? It's part of ISSAOComposite

Ah

Copy link
Collaborator

@FlayaN FlayaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait until this PR is completed #385 (update of clib-ng with your change as well in it do clib)

dev is now update with clib-ng with this RE included

@Jonahex Jonahex merged commit 7e71792 into doodlum:dev Aug 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants