Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pbr fixes #391

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix: pbr fixes #391

merged 2 commits into from
Aug 5, 2024

Conversation

Jonahex
Copy link
Collaborator

@Jonahex Jonahex commented Aug 5, 2024

Fixed missing dalc on pbr objects when ssgi disabled; removed double specular dalc application.

FlayaN
FlayaN previously requested changes Aug 5, 2024
Copy link
Collaborator

@FlayaN FlayaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower the length of the title, 72 is the recommended max for conventional commits (currently 101)

@Jonahex Jonahex changed the title fix: fixed missing dalc on pbr objects when ssgi disabled; removed double specular dalc application. fix: pbr fixes. Aug 5, 2024
@FlayaN FlayaN requested review from FlayaN and removed request for FlayaN August 5, 2024 19:22
@FlayaN FlayaN dismissed their stale review August 5, 2024 19:25

fixed

@doodlum doodlum changed the title fix: pbr fixes. fix: pbr fixes Aug 5, 2024
@doodlum doodlum merged commit 1d20338 into doodlum:dev Aug 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants