Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PBR directional light specular fix and llf compile fixes #415

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

doodlum
Copy link
Owner

@doodlum doodlum commented Aug 13, 2024

ScreenShot3950
ScreenShot3951

Fixes directional lights applying to the specular in interiors. This doesn't make sense for the specular since we already include ambient light like that in the dynamic cubemap.

Also fixes the light limit fix debug visualisations compile errors, and removes unneeded color clamping.

@Pentalimbed
Copy link
Collaborator

Pentalimbed commented Aug 13, 2024

Would that break certain interiors that has sunlight? Imo should check if it is shadowed too.

@Pentalimbed
Copy link
Collaborator

Pentalimbed commented Aug 13, 2024

Title should reflect better what it actually does.

@doodlum
Copy link
Owner Author

doodlum commented Aug 13, 2024

Would that break certain interiors that has sunlight? Imo should check if it is shadowed too.

It checks for this

@doodlum doodlum changed the title feat: lighting fixes feat: pbr directional light specular fix and llf compile fixes Aug 13, 2024
@doodlum
Copy link
Owner Author

doodlum commented Aug 13, 2024

Title should reflect better what it actually does.

There, changed it

@FlayaN
Copy link
Collaborator

FlayaN commented Aug 13, 2024

This is a fix: not a feat:

@doodlum
Copy link
Owner Author

doodlum commented Aug 13, 2024

I will rename it to fix because the LLF part at least is definitely a fix.

@doodlum doodlum changed the title feat: pbr directional light specular fix and llf compile fixes fix: pbr directional light specular fix and llf compile fixes Aug 13, 2024
@doodlum doodlum changed the title fix: pbr directional light specular fix and llf compile fixes fix: PBR directional light specular fix and llf compile fixes Aug 13, 2024
@Pentalimbed
Copy link
Collaborator

Would that break certain interiors that has sunlight? Imo should check if it is shadowed too.

It checks for this

Then I think I should have another name since it's not exactly all interior, or at least add a comment listing the exceptions.

@doodlum
Copy link
Owner Author

doodlum commented Aug 13, 2024

Would that break certain interiors that has sunlight? Imo should check if it is shadowed too.

It checks for this

Then I think I should have another name since it's not exactly all interior, or at least add a comment listing the exceptions.

Where would you like there to be a comment? The definition of "interior" is the same as defined by enbseries.

@Pentalimbed
Copy link
Collaborator

Pentalimbed commented Aug 13, 2024

Where would you like there to be a comment? The definition of "interior" is the same as defined by enbseries.

In SharedBuffer.hlsli, after the buffer variable definition, for example.

No matter what enb does, people who don't know how enb does things will be confused.

@doodlum
Copy link
Owner Author

doodlum commented Aug 13, 2024

Would "directional shadows" or similar be a better name?

@Pentalimbed
Copy link
Collaborator

Would "directional shadows" or similar be a better name?

Better than before, but don't some foggy weather or moonlight lacks shadow too iirc?

@doodlum
Copy link
Owner Author

doodlum commented Aug 13, 2024

Would "directional shadows" or similar be a better name?

Better than before, but don't some foggy weather or moonlight lacks shadow too iirc?

They still render shadow maps.

@Pentalimbed
Copy link
Collaborator

They still render shadow maps.

Ok, now rename the thing then

@doodlum doodlum merged commit e8bbc2a into dev Aug 13, 2024
@doodlum doodlum deleted the lighting-fixes branch August 13, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants